Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for new image types support for VmwareNodePool #11643

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

naitianliu-google
Copy link
Contributor

Update docs for new image types support for VmwareNodePool

Release Note Template for Downstream PRs (will be copied)

Update docs for new image types support for`google_gkeonprem_vmware_node_pool`

@github-actions github-actions bot requested a review from BBBmau September 5, 2024 17:31
Copy link

github-actions bot commented Sep 5, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 20
Passed tests: 19
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages
  • gkeonprem

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

@@ -113,7 +113,7 @@ properties:
required: true
description: |
The OS image to be used for each node in a node pool.
Currently `cos`, `ubuntu`, `ubuntu_containerd` and `windows` are supported.
Currently `cos`, `cos_cgv2`, `ubuntu`, `ubuntu_cgv2`, `ubuntu_containerd` and `windows` are supported.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you provide me a link of where it talks about the inclusion of these new node image types?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for asking. Here is the context of this change b/348187956

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry I don't have access to the link, is this not made public yet?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was helpful, thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants