Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore failing tests for AppEngine and IAP #11396

Merged
merged 9 commits into from
Aug 8, 2024
Merged

Ignore failing tests for AppEngine and IAP #11396

merged 9 commits into from
Aug 8, 2024

Conversation

slevenick
Copy link
Contributor

For tests failing in #11370

Release Note Template for Downstream PRs (will be copied)

@slevenick slevenick requested review from a team and melinath and removed request for a team August 8, 2024 14:07
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 1351 deletions(-))
google-beta provider: Diff ( 2 files changed, 1351 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 77
Passed tests: 59
Skipped tests: 18
Affected tests: 0

Click here to see the affected service packages
  • iap
  • appengine

$\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 1351 deletions(-))
google-beta provider: Diff ( 3 files changed, 19 insertions(+), 1351 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 77
Passed tests: 59
Skipped tests: 18
Affected tests: 0

Click here to see the affected service packages
  • appengine
  • iap

$\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 1351 deletions(-))
google-beta provider: Diff ( 3 files changed, 18 insertions(+), 1351 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 77
Passed tests: 59
Skipped tests: 18
Affected tests: 0

Click here to see the affected service packages
  • appengine
  • iap

$\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 1351 deletions(-))
google-beta provider: Diff ( 3 files changed, 20 insertions(+), 1351 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 77
Passed tests: 59
Skipped tests: 18
Affected tests: 0

Click here to see the affected service packages
  • iap
  • appengine

$\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 1351 deletions(-))
google-beta provider: Diff ( 3 files changed, 21 insertions(+), 1351 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 90
Passed tests: 70
Skipped tests: 18
Affected tests: 2

Click here to see the affected service packages
  • appengine
  • iap

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAppEngineFlexibleAppVersion_update
  • TestAccAppEngineStandardAppVersion_update

Get to know how VCR tests work

melinath
melinath previously approved these changes Aug 8, 2024
View reviewed changes
Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming tests pass

...hird_party/terraform/services/appengine/resource_app_engine_flexible_app_version_test.go.erb

"github.com/hashicorp/terraform-plugin-testing/helper/resource"
"github.com/hashicorp/terraform-plugin-testing/helper/resource"
"github.com/hashicorp/terraform-plugin-testing/terraform"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: seems like the indentation in the imports is inconsistent

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAppEngineFlexibleAppVersion_update[Error message] [Debug log]
TestAccAppEngineStandardAppVersion_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 1351 deletions(-))
google-beta provider: Diff ( 3 files changed, 23 insertions(+), 1351 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 77
Passed tests: 59
Skipped tests: 18
Affected tests: 0

Click here to see the affected service packages
  • appengine
  • iap

$\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 1351 deletions(-))
google-beta provider: Diff ( 3 files changed, 23 insertions(+), 1351 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 77
Passed tests: 59
Skipped tests: 18
Affected tests: 0

Click here to see the affected service packages
  • appengine
  • iap

$\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 2 insertions(+), 1351 deletions(-))
google-beta provider: Diff ( 4 files changed, 25 insertions(+), 1351 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 90
Passed tests: 70
Skipped tests: 20
Affected tests: 0

Click here to see the affected service packages
  • appengine
  • iap

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 1 insertion(+), 1351 deletions(-))
google-beta provider: Diff ( 4 files changed, 23 insertions(+), 1351 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 90
Passed tests: 70
Skipped tests: 20
Affected tests: 0

Click here to see the affected service packages
  • iap
  • appengine

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

@slevenick slevenick merged commit 24de582 into GoogleCloudPlatform:main Aug 8, 2024
13 checks passed
This was referenced Aug 8, 2024
Merged
Merged
rainshen49 pushed a commit to rainshen49/magic-modules that referenced this pull request Aug 12, 2024
@slevenick @rainshen49
Ignore failing tests for AppEngine and IAP (GoogleCloudPlatform#11396)
5994e89
BBBmau pushed a commit to bschaatsbergen/magic-modules that referenced this pull request Aug 21, 2024
@slevenick @BBBmau
Ignore failing tests for AppEngine and IAP (GoogleCloudPlatform#11396)
fcd2153
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melinath melinath melinath approved these changes

Assignees
No one assigned
Labels
service/appengine service/iap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slevenick @modular-magician @melinath