Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update bigtable version to 1.28.0 #11370

Merged
merged 7 commits into from
Aug 8, 2024

Conversation

ron-gal
Copy link
Contributor

@ron-gal ron-gal commented Aug 6, 2024

Release Note Template for Downstream PRs (will be copied)


@ron-gal ron-gal marked this pull request as ready for review August 6, 2024 13:54
Copy link

github-actions bot commented Aug 6, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from slevenick August 6, 2024 13:55
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 4 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 2 files changed, 4 insertions(+), 2 deletions(-))

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 4 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 2 files changed, 4 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3886
Passed tests: 3489
Skipped tests: 385
Affected tests: 12

Click here to see the affected service packages

All service packages are affected

Action taken

Found 12 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample
  • TestAccAppEngineFlexibleAppVersion_update
  • TestAccAppEngineStandardAppVersion_update
  • TestAccDataSourceArtifactRegistryDockerImage
  • TestAccIapAppEngineServiceIamBindingGenerated
  • TestAccIapAppEngineServiceIamBindingGenerated_withCondition
  • TestAccIapAppEngineServiceIamMemberGenerated
  • TestAccIapAppEngineServiceIamMemberGenerated_withCondition
  • TestAccIapAppEngineServiceIamPolicyGenerated
  • TestAccIapAppEngineServiceIamPolicyGenerated_withCondition
  • TestAccIapTunnelIamPolicyGenerated_withCondition
  • TestAccNetworkServicesLbRouteExtension_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3886
Passed tests: 3490
Skipped tests: 385
Affected tests: 11

Click here to see the affected service packages

All service packages are affected

Action taken

Found 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample
  • TestAccAppEngineFlexibleAppVersion_update
  • TestAccAppEngineStandardAppVersion_update
  • TestAccDataSourceArtifactRegistryDockerImage
  • TestAccIapAppEngineServiceIamBindingGenerated
  • TestAccIapAppEngineServiceIamBindingGenerated_withCondition
  • TestAccIapAppEngineServiceIamMemberGenerated
  • TestAccIapAppEngineServiceIamMemberGenerated_withCondition
  • TestAccIapAppEngineServiceIamPolicyGenerated
  • TestAccIapAppEngineServiceIamPolicyGenerated_withCondition
  • TestAccNetworkServicesLbRouteExtension_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample[Error message] [Debug log]
TestAccAppEngineFlexibleAppVersion_update[Error message] [Debug log]
TestAccAppEngineStandardAppVersion_update[Error message] [Debug log]
TestAccDataSourceArtifactRegistryDockerImage[Error message] [Debug log]
TestAccIapAppEngineServiceIamBindingGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamBindingGenerated_withCondition[Error message] [Debug log]
TestAccIapAppEngineServiceIamMemberGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamMemberGenerated_withCondition[Error message] [Debug log]
TestAccIapAppEngineServiceIamPolicyGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamPolicyGenerated_withCondition[Error message] [Debug log]
TestAccNetworkServicesLbRouteExtension_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccIapTunnelIamPolicyGenerated_withCondition[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample[Error message] [Debug log]
TestAccAppEngineFlexibleAppVersion_update[Error message] [Debug log]
TestAccAppEngineStandardAppVersion_update[Error message] [Debug log]
TestAccDataSourceArtifactRegistryDockerImage[Error message] [Debug log]
TestAccIapAppEngineServiceIamBindingGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamBindingGenerated_withCondition[Error message] [Debug log]
TestAccIapAppEngineServiceIamMemberGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamMemberGenerated_withCondition[Error message] [Debug log]
TestAccIapAppEngineServiceIamPolicyGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamPolicyGenerated_withCondition[Error message] [Debug log]
TestAccNetworkServicesLbRouteExtension_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

@slevenick
Copy link
Contributor

/gcbrun there are lots of test failures, I hope they're not related to this change, that would be bad

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 4 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 2 files changed, 4 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3889
Passed tests: 3495
Skipped tests: 383
Affected tests: 11

Click here to see the affected service packages

All service packages are affected

Action taken

Found 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample
  • TestAccAppEngineFlexibleAppVersion_update
  • TestAccAppEngineStandardAppVersion_update
  • TestAccDataSourceArtifactRegistryDockerImage
  • TestAccIapAppEngineServiceIamBindingGenerated
  • TestAccIapAppEngineServiceIamBindingGenerated_withCondition
  • TestAccIapAppEngineServiceIamMemberGenerated
  • TestAccIapAppEngineServiceIamMemberGenerated_withCondition
  • TestAccIapAppEngineServiceIamPolicyGenerated
  • TestAccIapAppEngineServiceIamPolicyGenerated_withCondition
  • TestAccNetworkServicesLbRouteExtension_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample[Error message] [Debug log]
TestAccAppEngineFlexibleAppVersion_update[Error message] [Debug log]
TestAccAppEngineStandardAppVersion_update[Error message] [Debug log]
TestAccDataSourceArtifactRegistryDockerImage[Error message] [Debug log]
TestAccIapAppEngineServiceIamBindingGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamBindingGenerated_withCondition[Error message] [Debug log]
TestAccIapAppEngineServiceIamMemberGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamMemberGenerated_withCondition[Error message] [Debug log]
TestAccIapAppEngineServiceIamPolicyGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamPolicyGenerated_withCondition[Error message] [Debug log]
TestAccNetworkServicesLbRouteExtension_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 7 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 8 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3893
Passed tests: 3500
Skipped tests: 386
Affected tests: 7

Click here to see the affected service packages

All service packages are affected

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample
  • TestAccIapAppEngineServiceIamBindingGenerated
  • TestAccIapAppEngineServiceIamBindingGenerated_withCondition
  • TestAccIapAppEngineServiceIamMemberGenerated
  • TestAccIapAppEngineServiceIamMemberGenerated_withCondition
  • TestAccIapAppEngineServiceIamPolicyGenerated
  • TestAccIapAppEngineServiceIamPolicyGenerated_withCondition

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample[Error message] [Debug log]
TestAccIapAppEngineServiceIamBindingGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamBindingGenerated_withCondition[Error message] [Debug log]
TestAccIapAppEngineServiceIamMemberGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamMemberGenerated_withCondition[Error message] [Debug log]
TestAccIapAppEngineServiceIamPolicyGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamPolicyGenerated_withCondition[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 7 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 8 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3893
Passed tests: 3500
Skipped tests: 386
Affected tests: 7

Click here to see the affected service packages

All service packages are affected

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample
  • TestAccIapAppEngineServiceIamBindingGenerated
  • TestAccIapAppEngineServiceIamBindingGenerated_withCondition
  • TestAccIapAppEngineServiceIamMemberGenerated
  • TestAccIapAppEngineServiceIamMemberGenerated_withCondition
  • TestAccIapAppEngineServiceIamPolicyGenerated
  • TestAccIapAppEngineServiceIamPolicyGenerated_withCondition

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample[Error message] [Debug log]
TestAccIapAppEngineServiceIamBindingGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamBindingGenerated_withCondition[Error message] [Debug log]
TestAccIapAppEngineServiceIamMemberGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamMemberGenerated_withCondition[Error message] [Debug log]
TestAccIapAppEngineServiceIamPolicyGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamPolicyGenerated_withCondition[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 6 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 6 insertions(+), 2 deletions(-))

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 6 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 6 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3890
Passed tests: 3506
Skipped tests: 384
Affected tests: 0

Click here to see the affected service packages

All service packages are affected

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3890
Passed tests: 3506
Skipped tests: 384
Affected tests: 0

Click here to see the affected service packages

All service packages are affected

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

@slevenick slevenick merged commit e19a511 into GoogleCloudPlatform:main Aug 8, 2024
11 checks passed
rainshen49 pushed a commit to rainshen49/magic-modules that referenced this pull request Aug 12, 2024
BBBmau pushed a commit to bschaatsbergen/magic-modules that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants