Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move x-http-method-override to beginning of filter chain #801

Merged
merged 4 commits into from
Mar 28, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert find-replace
Signed-off-by: Teju Nareddy <[email protected]>
  • Loading branch information
nareddyt committed Mar 28, 2023
commit 96a955e3eb8bb28d222996ba6258e3f53cd9839d
Original file line number Diff line number Diff line change
Expand Up @@ -140,17 +140,17 @@ func TestHttp1JWT(t *testing.T) {
wantedError: `{"code":404,"message":"The current request is not defined by this API."}`,
},
{
desc: "Fail, without valid JWT token",
desc: "Fail, with valid JWT token",
httpMethod: "GET",
httpPath: "/auth/info/googleservicecontrol.googleapis.com:443/",
wantedError: `{"code":404,"message":"The current request is not defined by this API."}`,
httpPath: "/auth/info/googlejwt",
token: testdata.FakeBadToken,
wantedError: "401 Unauthorized",
},
{
desc: "Succeed, with valid JWT token, with allowed audience",
httpMethod: "GET",
httpPath: "/auth/info/auth0",
token: testdata.FakeCloudTokenSingleAudience2,
wantResp: `{"aud":"admin.cloud.goog","exp":4698318995,"iat":1544718995,"iss":"[email protected]","sub":"[email protected]"}`,
desc: "Fail, without valid JWT token",
httpMethod: "GET",
httpPath: "/auth/info/googlejwt",
wantedError: "401 Unauthorized",
},
{
desc: "Fail, with valid JWT token, without allowed audience",
Expand Down