Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move x-http-method-override to beginning of filter chain #801

Merged
merged 4 commits into from
Mar 28, 2023
Merged

move x-http-method-override to beginning of filter chain #801

merged 4 commits into from
Mar 28, 2023

Conversation

nareddyt
Copy link
Contributor

Create a new filter to handle method override. Tested via integration test.

@nareddyt
move x-http-method-override to beginning of filter chain
38ad42b 
Create a new filter to handle method override. Tested via integration test.
@nareddyt nareddyt added the enhancement New feature or request label Mar 27, 2023
@nareddyt nareddyt requested review from shuoyang2016 and TAOXUY March 27, 2023 22:21
@nareddyt nareddyt self-assigned this Mar 27, 2023
@google-oss-prow google-oss-prow bot added the lgtm label Mar 27, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nareddyt, shuoyang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [nareddyt,shuoyang2016]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nareddyt
Fix another integration test
39e57ad 
Signed-off-by: Teju Nareddy <[email protected]>
@google-oss-prow google-oss-prow bot removed the lgtm label Mar 28, 2023
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@google-oss-prow google-oss-prow bot added size/XL and removed size/L labels Mar 28, 2023
nareddyt added 2 commits March 28, 2023 00:57
@nareddyt
Revert find-replace
96a955e 
Signed-off-by: Teju Nareddy <[email protected]>
@nareddyt
Revert find-replace
a228701 
Signed-off-by: Teju Nareddy <[email protected]>
@google-oss-prow google-oss-prow bot added size/L and removed size/XL labels Mar 28, 2023
@nareddyt
Copy link
Contributor Author

/retest

@google-oss-prow
Copy link

google-oss-prow bot commented Mar 28, 2023 •
edited
Loading

@nareddyt: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ESPv2-anthos-cloud-run-e2e-anthos-cloud-run-http-bookstore a228701 link true /test ESPv2-anthos-cloud-run-e2e-anthos-cloud-run-http-bookstore
ESPv2-API-regression-test a228701 link true /test ESPv2-API-regression-test
ESPv2-presubmit-asan a228701 link true /test ESPv2-presubmit-asan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nareddyt nareddyt merged commit e956701 into GoogleCloudPlatform:master Mar 28, 2023
@nareddyt nareddyt deleted the method-override branch March 28, 2023 04:24
@nareddyt nareddyt mentioned this pull request Mar 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuoyang2016 shuoyang2016 shuoyang2016 approved these changes

@TAOXUY TAOXUY Awaiting requested review from TAOXUY

Assignees

@shuoyang2016 shuoyang2016

@nareddyt nareddyt

Labels
approved enhancement New feature or request size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nareddyt @shuoyang2016