Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ssl_minimum_protocol and ssl_maximum_protocol for downstream #58

Merged
merged 3 commits into from
Mar 10, 2020
Merged

add ssl_minimum_protocol and ssl_maximum_protocol for downstream #58

merged 3 commits into from
Mar 10, 2020

Conversation

JLXIA
Copy link
Contributor

@JLXIA JLXIA commented Mar 9, 2020

Support ssl_minimum_protocol and ssl_maximum_protocol for downstream

nareddyt
nareddyt approved these changes Mar 9, 2020
View reviewed changes
docker/generic/start_proxy.py Show resolved Hide resolved
@google-oss-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JLXIA, nareddyt, qiwzhang, TAOXUY

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JLXIA,TAOXUY,nareddyt,qiwzhang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JLXIA

This comment has been minimized.

Sign in to view
@google-oss-robot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@JLXIA
Copy link
Contributor Author

JLXIA commented Mar 9, 2020

/retest

@nareddyt
Copy link
Contributor

nareddyt commented Mar 9, 2020

Please ignore the coverage job failure until #56 is merged

@JLXIA

This comment has been minimized.

Sign in to view
@JLXIA

This comment has been minimized.

Sign in to view
@JLXIA

This comment has been minimized.

Sign in to view
@JLXIA

This comment has been minimized.

Sign in to view
@google-oss-robot
Copy link
Collaborator

google-oss-robot commented Mar 10, 2020 •
edited
Loading

@JLXIA: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ESPv2-presubmit-coverage 048b5a4 link /test ESPv2-presubmit-coverage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JLXIA JLXIA merged commit 04f0bc5 into GoogleCloudPlatform:master Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nareddyt nareddyt nareddyt approved these changes

@qiwzhang qiwzhang qiwzhang approved these changes

@TAOXUY TAOXUY TAOXUY approved these changes

Assignees

@nareddyt nareddyt

@qiwzhang qiwzhang

@TAOXUY TAOXUY

Labels
approved size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JLXIA @google-oss-robot @nareddyt @qiwzhang @TAOXUY