-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add script to upload publicly-viewable C++ unit test coverage data #56
Conversation
Signed-off-by: Teju Nareddy <[email protected]>
Signed-off-by: Teju Nareddy <[email protected]>
Signed-off-by: Teju Nareddy <[email protected]>
/test ESPv2-presubmit-coverage |
Signed-off-by: Teju Nareddy <[email protected]>
New image has JDK. This unblocks coverage reports: GoogleCloudPlatform/esp-v2#56 Signed-off-by: Teju Nareddy <[email protected]>
Signed-off-by: Teju Nareddy <[email protected]>
New image has JDK. This unblocks coverage reports: GoogleCloudPlatform/esp-v2#56 Signed-off-by: Teju Nareddy <[email protected]>
Blocked by GoogleCloudPlatform/oss-test-infra#318 |
/test ESPv2-presubmit-coverage |
Signed-off-by: Teju Nareddy <[email protected]>
Signed-off-by: Teju Nareddy <[email protected]>
Signed-off-by: Teju Nareddy <[email protected]>
set -eo pipefail | ||
|
||
gcloud config set core/project cloudesf-testing | ||
gcloud auth activate-service-account \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe login by referencing env instead of absolute path?
BTW, I looked at our other jobs, which all include the project setting step but no activate-service-account step t so maybe you can try removing no activate-service-account step
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, let's use env var.
I double checked some other jobs, it seems like they aren't using the correct service account. They are still using the default prow one as far as I can tell. Take a look at the first few lines here: https://oss-prow.knative.dev/view/gcs/oss-prow/pr-logs/pull/GoogleCloudPlatform_esp-v2/56/ESPv2-presubmit/1237771179012395010
Let's keep the activation in this script. I'm make another PR to either make this consistent across all non-kubekins scripts or try to debug why it's not activated by default.
Signed-off-by: Teju Nareddy <[email protected]>
Signed-off-by: Teju Nareddy <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nareddyt, qiwzhang, TAOXUY The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Example test coverage report: https://storage.googleapis.com/esp-v2-coverage/local-run/third_party/tools/coverage/coverage_tests/index.html
Waiting for GoogleCloudPlatform/oss-test-infra#314 to auto-generate reports per PR.
Signed-off-by: Teju Nareddy [email protected]