Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script to upload publicly-viewable C++ unit test coverage data #56

Merged
merged 11 commits into from
Mar 11, 2020

Conversation

nareddyt
Copy link
Contributor

@nareddyt nareddyt commented Mar 7, 2020

Signed-off-by: Teju Nareddy <[email protected]>
@nareddyt
Copy link
Contributor Author

nareddyt commented Mar 9, 2020

/test ESPv2-presubmit-coverage

nareddyt added a commit to nareddyt/oss-test-infra that referenced this pull request Mar 10, 2020
New image has JDK. This unblocks coverage reports: GoogleCloudPlatform/esp-v2#56

Signed-off-by: Teju Nareddy <[email protected]>
Signed-off-by: Teju Nareddy <[email protected]>
nareddyt added a commit to nareddyt/oss-test-infra that referenced this pull request Mar 10, 2020
New image has JDK. This unblocks coverage reports: GoogleCloudPlatform/esp-v2#56

Signed-off-by: Teju Nareddy <[email protected]>
@nareddyt
Copy link
Contributor Author

Blocked by GoogleCloudPlatform/oss-test-infra#318

@nareddyt
Copy link
Contributor Author

/test ESPv2-presubmit-coverage

Signed-off-by: Teju Nareddy <[email protected]>
Signed-off-by: Teju Nareddy <[email protected]>
Signed-off-by: Teju Nareddy <[email protected]>
@nareddyt nareddyt requested a review from TAOXUY March 10, 2020 23:39
@nareddyt nareddyt requested a review from qiwzhang March 10, 2020 23:48
set -eo pipefail

gcloud config set core/project cloudesf-testing
gcloud auth activate-service-account \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe login by referencing env instead of absolute path?
BTW, I looked at our other jobs, which all include the project setting step but no activate-service-account step t so maybe you can try removing no activate-service-account step

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, let's use env var.

I double checked some other jobs, it seems like they aren't using the correct service account. They are still using the default prow one as far as I can tell. Take a look at the first few lines here: https://oss-prow.knative.dev/view/gcs/oss-prow/pr-logs/pull/GoogleCloudPlatform_esp-v2/56/ESPv2-presubmit/1237771179012395010

Let's keep the activation in this script. I'm make another PR to either make this consistent across all non-kubekins scripts or try to debug why it's not activated by default.

Signed-off-by: Teju Nareddy <[email protected]>
Signed-off-by: Teju Nareddy <[email protected]>
@nareddyt nareddyt requested a review from TAOXUY March 11, 2020 16:16
@google-oss-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nareddyt, qiwzhang, TAOXUY

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [TAOXUY,nareddyt,qiwzhang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nareddyt nareddyt merged commit ece259a into GoogleCloudPlatform:master Mar 11, 2020
@nareddyt nareddyt deleted the coverage branch March 11, 2020 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants