Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: add drift region tags #611

Merged
merged 10 commits into from
Feb 15, 2022
Merged

cleanup: add drift region tags #611

merged 10 commits into from
Feb 15, 2022

Conversation

xtineskim
Copy link
Contributor

@xtineskim xtineskim commented Feb 4, 2022 •
edited
Loading

Fixes

n/a

Background

Ongoing effort of adding region tags to our yaml and shell files in our repos. Allows for our team to leverage internal tools

Change Summary

  • Added region tags. Snippet-bot will add a comment below of the tags added (and where).

    • Tags are gke_... and servicemesh_...

  • For the kubernetes-manifests, the tags in the dev-manifests folder will just be copied over every time we make a release. From my understanding, the files in dev-kubernetes-manifests and kubernetes-manifests are the same, besides the versioning for our interests.

    • Since we don't allow for duplicate tags, I edited the make-release.sh to edit the tags to be ...boa_kubernetes-manifests... (replaces dev with boa section in the tag). While the release files don't have any tags right now, they will appear next time we have a release

Additional Notes

Since there were no existing region tags in this repo, we don't have to worry about any internal references to tags (ie no existing code widgets, and no broken code samples)
Also please note that this update will take a few hours or more to reflect internally once it's merged.

Testing Procedure

n/a

Related PRs or Issues

Similar to microservice-demo PR that has been merged.

@xtineskim xtineskim requested a review from a team as a code owner February 4, 2022 20:26
@snippet-bot
Copy link

snippet-bot bot commented Feb 4, 2022 •
edited
Loading

Here is the summary of changes.

You are about to add 83 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@xtineskim xtineskim requested a review from askmeegs February 4, 2022 20:26
@github-actions
Copy link

github-actions bot commented Feb 4, 2022

🚀 PR staged at http://35.222.154.147

bourgeoisor
bourgeoisor approved these changes Feb 5, 2022
View reviewed changes
Copy link
Member

@bourgeoisor bourgeoisor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, just a small comment.
Thank you for the typo fix :)

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

🚀 PR staged at http://35.222.154.147

@github-actions
Copy link

🚀 PR staged at http://35.222.154.147

@github-actions
Copy link

🚀 PR staged at http://35.222.154.147

@github-actions
Copy link

🚀 PR staged at http://35.222.154.147

@xtineskim xtineskim merged commit 8c3a5ae into main Feb 15, 2022
@bourgeoisor bourgeoisor mentioned this pull request Feb 16, 2022
Merged
@xtineskim xtineskim mentioned this pull request Feb 18, 2022
Merged
@xtineskim xtineskim deleted the drift_region_tags branch February 18, 2022 16:16
@xtineskim xtineskim mentioned this pull request Feb 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askmeegs askmeegs askmeegs approved these changes

@bourgeoisor bourgeoisor bourgeoisor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xtineskim @askmeegs @bourgeoisor