Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: adding DRIFT region tags to yaml and sh files #173

Merged
merged 18 commits into from
Mar 2, 2022

Conversation

xtineskim
Copy link
Contributor

@xtineskim xtineskim commented Feb 18, 2022

Fixes

n/a

Description

Ongoing effort of adding region tags to our yaml and shell files in our repos. Allows for our team to leverage internal tool

Change summary

  • Added region tags. Snippet-bot will add a comment below of the tags added (and where).
  • Also updated the tf files that had anthos_bm to be wrapped with anthosbaremetal tags. Will create a CL to update our docs.

Related PRs/Issues

Similar PRs can be found here microservice-demo PR, bank-of-anthos PR

@xtineskim xtineskim requested review from askmeegs and a team February 18, 2022 16:13
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Feb 18, 2022
@snippet-bot
Copy link

snippet-bot bot commented Feb 18, 2022

Here is the summary of changes.

You are about to add 53 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@xtineskim xtineskim changed the title Drift region tags cleanup: adding DRIFT region tags to yaml and sh files Feb 18, 2022
Copy link
Collaborator

@askmeegs askmeegs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! One quick thing, may be worth replacing : with _ in any tag with a semicolon.

@xtineskim xtineskim requested a review from askmeegs February 22, 2022 18:58
@xtineskim xtineskim requested a review from a team as a code owner February 23, 2022 21:13
Copy link
Member

@Shabirmean Shabirmean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@xtineskim xtineskim merged commit 6cf8651 into main Mar 2, 2022
@xtineskim xtineskim deleted the drift_region_tags branch March 2, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants