-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup: adding DRIFT region tags to yaml and sh files #173
Conversation
Here is the summary of changes. You are about to add 53 region tags.
This comment is generated by snippet-bot.
|
…thos-samples into drift_region_tags
…thos-samples into drift_region_tags
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! One quick thing, may be worth replacing :
with _
in any tag with a semicolon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes
n/a
Description
Ongoing effort of adding region tags to our yaml and shell files in our repos. Allows for our team to leverage internal tool
Change summary
anthos_bm
to be wrapped withanthosbaremetal
tags. Will create a CL to update our docs.Related PRs/Issues
Similar PRs can be found here microservice-demo PR, bank-of-anthos PR