This repository has been archived by the owner on Aug 31, 2021. It is now read-only.
Only attempt to cache GET requests #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes LGTM. Would like an LGTM2 by @jeffposnick before we land this. Thanks Mat! |
|
Hey @jeffposnick, Addy wanted another LGTM for this. I think this solves Polymer/polymer-starter-kit#64 |
|
friendly ping @jeffposnick |
|
Sorry, missed this! If you feel like combining |
|
SG. @wibblymat I'll leave it up to you to merge when you're happy with whether to make the above adjustment or not :) |
wibblymat
force-pushed
the
only-cache-get
branch
2 times, most recently
from
4bb1715 to
c60f225
Compare
Caching other types of request is prohibited by the spec. Closes #10
|
Made the change. Will merge and tag v2.0.2 |
wibblymat
added a commit
that referenced
this pull request
Jun 3, 2015
Only attempt to cache GET requests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caching other types of request is prohibited by the spec and can result in console error spam.
Closes #10
R: @addyosmani @jeffposnick