Only attempt to cache GET requests

Caching other types of request is prohibited by the spec. Closes #10
GoogleChromeLabs · Jun 3, 2015 · 4bb1715 · 4bb1715
1 parent c6baaa2
commit 4bb1715
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/lib/helpers.js b/lib/helpers.js
@@ -19,7 +19,7 @@ var globalOptions = require('./options');
 
 function debug(message, options) {
   options = options || {};
-  var flag = options.debug || globalOptions.debug;  
+  var flag = options.debug || globalOptions.debug;
   if (flag) {
     console.log('[sw-toolbox] ' + message);
   }
@@ -34,11 +34,11 @@ function openCache(options) {
 
 function fetchAndCache(request, options) {
   options = options || {};
-  var successResponses = options.successResponses || globalOptions.successResponses;  
+  var successResponses = options.successResponses || globalOptions.successResponses;
   return fetch(request.clone()).then(function(response) {
 
-    // Only cache successful responses
-    if (successResponses.test(response.status)) {
+    // Only cache GET requests with successful responses
+    if (request.method === 'GET' && successResponses.test(response.status)) {
       openCache(options).then(function(cache) {
         cache.put(request, response);
       });
@@ -76,4 +76,4 @@ module.exports = {
   fetchAndCache: fetchAndCache,
   openCache: openCache,
   renameCache: renameCache
-};
+};