-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix backslashes replacement. #774
Conversation
This resulted in backslashes in the URL entries on Windows.
The AppVeyor failure seems unrelated to this change. On a side note, I could add a test if you could give me some hints, i.e. which file the test should be, if I should just check for backslashes in |
Thanks for this @XkhmikosR. I'm waiting on a Windows machine to test this a little more. I'm largely curious to see if I can add some tests that "fake" windows files paths so we can test on linux for Window "style" support. |
@gauntface: you have AppVeyor so you can actually test Windows at any time https://www.appveyor.com/docs/how-to/rdp-to-build-worker/ It shouldn't be too hard to have a test for that. You could use https://nodejs.org/api/path.html#path_path_win32 or just hardcode the backslashes in a test case and just check if there are any in the output regardless of the OS. |
@gauntface Change here LGTM, but I don't have access to our AppVeyor account to follow the windows test instructions @XhmikosR linked up to. If you get a chance can you add me or test it out? Would love to see if we can unblock twbs/bootstrap#23533 |
Would be nice if we had a test to ensure this doesn't happen again in the future, though :) |
Gonna accept this merge and dig into a way of testing this better. Windows has been awful for a while and frankly I'm stumped on a sane way to test for it. @addyosmani tried adding you to AppVeyor but no idea how the hell it's "teams" works |
Thanks again for this @XhmikosR - this will be cut in the release tomorrow. |
@gauntface thanks, can we get 2.0.1 published to npm too please |
Sorry, there were a few hiccups with the |
This resulted in backslashes in the URL entries on Windows.
R: @jeffposnick @addyosmani @gauntface
Fixes #771