Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

entry.url is using Windows separator #771

Closed
XhmikosR opened this issue Aug 26, 2017 · 2 comments
Closed

entry.url is using Windows separator #771

XhmikosR opened this issue Aug 26, 2017 · 2 comments

Comments

@XhmikosR
Copy link
Contributor

Hi, there.

We are trying to precache our static assets for Bootstrap in this PR: twbs/bootstrap#23533

With workbox-build v2.0.0 on Windows, I'm getting this:

  {
    "url": "about\\index.html",
    "revision": "f9307e727e85be5a2a420ca9a44a4f01"
  },

I can just do a replace for the backslashes, but I wonder if this should happen in the first place? I know that URLs do not use backslashes but here maybe this is normal?

Thanks!

@gauntface
Copy link

No this is definitely a bug, so thank you for raising this. I'm not sure how this is happening though as we have tests to check for this. Will have a look.

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Aug 28, 2017

I had a quick look and it seems the issue is caused by path.join here

If you use path.posix.join it works but I guess that is not the place to make the change.

OK I think I figured it out; see #774.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants