-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make nodata
casting consistent based on new array type
#531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodata
casting consistent based on expected new array type, including NumPy/Python operationnodata
casting consistent based on new array type including NumPy operations
nodata
casting consistent based on new array type including NumPy operationsnodata
casting consistent based on new array type
adehecq
reviewed
Apr 8, 2024
adehecq
reviewed
Apr 8, 2024
adehecq
reviewed
Apr 8, 2024
adehecq
reviewed
Apr 8, 2024
adehecq
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good ! There's just a block of code that was deleted but I don't understand why.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the fact that
set_nodata
was circumvented duringfrom_array()
creation, making the behaviour fully consistent for checking nodata input and setting.Additionally, for practicality, it adds a
cast_nodata
boolean argument tofrom_array()
defaulting toTrue
which re-casts the inputnodata
to the default of the array type, if the nodata value was incompatible with the input array type.The impact of this last change was actually much less of a bigger than I thought, because all integer nodata values are compatible with floating array types and the other direction rarely happens. There is almost no NumPy operations that convert from
float
toint
(even operations like floordiv keep the output a float even if the output of the operation could technically be integers without loss of information, for instance).So this mostly addresses the cases where the user is copying the data with a new array that has different data type (fairly common), or provided a non-compatible nodata value directly to from_array (less common).
Resolves #517
Resolves #516
TO-DO:
set_nodata()
in from_array section of__init__()
,Raster.copy()
,