How do we keep track of changes waiting on a higher MSRV? #1782
-
Some changes cannot be made now but are planned for when the minimum supported Rust version is high enough to support them (either to make a language or library feature available, or for it to be stabilized). This includes at least the following: There may be others such closed PRs. There are also various MSRV-related TODO comments, such as: Lines 90 to 95 in 8df0db2 gitoxide/gix-merge/src/blob/builtin_driver/text/mod.rs Lines 106 to 108 in 8df0db2 How are, or should, such plans be tracked? Comments are one way of tracking them, of course, but there does not always seem to be such a comment, and sometimes a change would touch several places in the code (such as using |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 1 reply
-
A good point, thanks for bringing it up. Intuitively, without getting too much into github issues and release planning, I felt that adding categories to TODOs like Then once could look for all categorised TODO's easily, and in case of the MSRV, one could add a note to the one spot where the MSRV is changed (msrv.yml) to look for This would mean that ideally, each TODO has some sort of category. As far as I know, there are two of these already: performance/perf and borrowchk. |
Beta Was this translation helpful? Give feedback.
A good point, thanks for bringing it up.
Intuitively, without getting too much into github issues and release planning, I felt that adding categories to TODOs like
TODO(category)
would help to find related TODOs. I'd think that placing it in one or more strategic positions will help to also discover more, similar items.Then once could look for all categorised TODO's easily, and in case of the MSRV, one could add a note to the one spot where the MSRV is changed (msrv.yml) to look for
TODO(msrv)
for instance to see if some of these TODOs can now be resolved.This would mean that ideally, each TODO has some sort of category. As far as I know, there are two of these already: performance/perf…