Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use NotADirectory io error kind where appropriate #1775

Closed
wants to merge 1 commit into from
Closed

use NotADirectory io error kind where appropriate #1775

wants to merge 1 commit into from

Conversation

dvtkrlbs
Copy link
Contributor

No description provided.

@dvtkrlbs
Copy link
Contributor Author

hmm interestingly enough locally msrv check passed or maybe I ran it wrong

@dvtkrlbs dvtkrlbs marked this pull request as draft January 18, 2025 02:53
@dvtkrlbs
Copy link
Contributor Author

oh yeah my bad the actual msrv is defined at the workflow I missed that

@Byron
Copy link
Member

Byron commented Jan 18, 2025

Thanks a lot for bringing this up!

As it looks like it will be a while until gitoxide arrives at Rust v1.83, I'd like to close this PR in the hopes I will also remember once the MSRV here reaches 1.83 to bring it back.

@Byron Byron closed this Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dvtkrlbs @Byron