Skip to content
This repository has been archived by the owner on Feb 21, 2019. It is now read-only.

Refactor plugin to work on a line-basis. Also fix #9 #10

Merged
merged 27 commits into from
Dec 14, 2016
Merged

Refactor plugin to work on a line-basis. Also fix #9 #10

merged 27 commits into from
Dec 14, 2016

Conversation

Soreine
Copy link
Contributor

@Soreine Soreine commented Dec 12, 2016 •
edited
Loading

Breaking change.

  • Changed the structure to have code lines within code blocks
  • Optimized a bit the Schema
  • Added option for Shift+Enter handling (must provide the type of the block to exit to)

@Soreine Soreine requested a review from SamyPesse December 14, 2016 10:34
@Soreine Soreine changed the title Refactor plugin to work on a line-basis. Also fix #9 [WIP] Refactor plugin to work on a line-basis. Also fix #9 Dec 14, 2016
@Soreine Soreine removed the request for review from SamyPesse December 14, 2016 10:44
@Soreine Soreine changed the title Refactor plugin to work on a line-basis. Also fix #9 Refactor plugin to work on a line-basis. Also fix #9 [WIP 👷‍♀️] Dec 14, 2016
@Soreine Soreine requested a review from SamyPesse December 14, 2016 14:19
@Soreine Soreine changed the title Refactor plugin to work on a line-basis. Also fix #9 [WIP 👷‍♀️] Refactor plugin to work on a line-basis. Also fix #9 Dec 14, 2016
SamyPesse
SamyPesse suggested changes Dec 14, 2016
View reviewed changes
Copy link
Member

@SamyPesse SamyPesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Command+A doesn't work anymore and there should be a test for it.

@SamyPesse SamyPesse merged commit bc4ef07 into master Dec 14, 2016
@SamyPesse SamyPesse deleted the fix/9-unindent branch December 14, 2016 14:39
Soreine added a commit that referenced this pull request May 12, 2017
@Soreine
Remove inadequate TODO, see #10
2210be0
Soreine added a commit that referenced this pull request May 12, 2017
@Soreine
Remove case for text nodes only (see #10)
2034674
Soreine added a commit that referenced this pull request May 12, 2017
@Soreine
Merge pull request #12 from GitbookIO/fix/default-block
3bcc904 
Fix #10: default block in items, and documented schema
@echenley echenley mentioned this pull request May 18, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SamyPesse SamyPesse SamyPesse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Soreine @SamyPesse