Skip to content
This repository has been archived by the owner on Feb 21, 2019. It is now read-only.

Prism highlighting does not update all lines when changing syntax #17

Closed
echenley opened this issue May 18, 2017 · 1 comment
Closed
Labels

Comments

@echenley
Copy link

echenley commented May 18, 2017

This probably has something to do with the lines refactor: #10. The more basic Slate code-highlighting example does not have this issue: http://slatejs.org/#/code-highlighting

Steps to Reproduce

  • open a document on gitbook.com
  • make a code block with
var line1;
var line2;
  • change syntax to javascript, then to css
  • only currently focused line is updated
  • if you focus the beginning of the incorrectly highlighted line, it triggers prism to update it
  • if you focus the end of the incorrectly highlighted line, it throws an error
@echenley echenley changed the title Lines does not trigger prism Prism highlighting does not update all lines when changing syntax May 18, 2017
@echenley echenley reopened this May 18, 2017
@Soreine Soreine added the bug label Jun 20, 2017
@Soreine
Copy link
Contributor

Soreine commented Nov 7, 2017

Fixed in GitbookIO/slate-prism#5

@Soreine Soreine closed this as completed Nov 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants