Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Position of GadflyDisplay in Base.Multimedia.displays #1373

Merged
merged 1 commit into from
Jan 18, 2020

Conversation

Mattriks
Copy link
Member

  • I've built the docs and confirmed these changes don't cause new errors
  • I've tested this in the REPL, IJulia and vscode. I presume it also works in Juno.

This PR

Example (in IJulia)

# The GadflyDisplay doesn't need to override IJulia's Display 
using Gadfly
Base.Multimedia.displays

3-element Array{AbstractDisplay,1}:
TextDisplay(Base.TTY(Base.Libc.WindowsRawSocket(0x0000000000000298) open, 0 bytes waiting))
 Gadfly.GadflyDisplay()                                                                     
 IJulia.InlineDisplay()

@codecov-io
Copy link

Codecov Report

Merging #1373 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1373   +/-   ##
=======================================
  Coverage   90.55%   90.55%           
=======================================
  Files          38       38           
  Lines        3961     3961           
=======================================
  Hits         3587     3587           
  Misses        374      374
Impacted Files Coverage Δ
src/Gadfly.jl 78.14% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee4b5ae...630a803. Read the comment docs.

@Mattriks Mattriks changed the title Posiiton of GadflyDisplay in Base.Multimedia.displays Position of GadflyDisplay in Base.Multimedia.displays Dec 23, 2019
@bjarthur
Copy link
Member

@montyvesselinov can you please confirm this PR does not break support for terminalextension that i added at your request. i don't think it will but want to double check.

@bjarthur
Copy link
Member

@montyvesselinov this works for you?

@bjarthur bjarthur merged commit 13da0b0 into GiovineItalia:master Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gadfly doesn't show plots in julia-vscode plot pane.
3 participants