Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support TerminalExtensions.jl #1232

Merged
merged 1 commit into from
Mar 5, 2019
Merged

Conversation

bjarthur
Copy link
Member

Fixes #1230 @montyvesselinov

ideally it would be nice to replace the popdisplay(GadflyDisplay) in src/terminalextensions.jl with code to put GadflyDisplay before iTerm2.InlineDisplay. as a fallback in case you have TerminalExtensions in your startup.jl, but are using a terminal which is not supported. one can get a typeof(Base.Multimedia.displays[i]), but how does one tell which module that type was defined in?

@codecov-io
Copy link

codecov-io commented Dec 30, 2018

Codecov Report

Merging #1232 into master will decrease coverage by 0.55%.
The diff coverage is 20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1232      +/-   ##
==========================================
- Coverage   85.74%   85.19%   -0.56%     
==========================================
  Files          35       36       +1     
  Lines        4119     4128       +9     
==========================================
- Hits         3532     3517      -15     
- Misses        587      611      +24
Impacted Files Coverage Δ
src/terminalextensions.jl 0% <0%> (ø)
src/mapping.jl 83.01% <100%> (-0.95%) ⬇️
src/Gadfly.jl 74.51% <33.33%> (-0.79%) ⬇️
src/theme.jl 61.4% <0%> (-8.78%) ⬇️
src/misc.jl 57.69% <0%> (-5.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82922a3...5ace17b. Read the comment docs.

@bjarthur
Copy link
Member Author

bjarthur commented Mar 3, 2019

@montyvesselinov can you please see if this PR works for you? i just pushed some changes that use dispatch to put the iTerm2 display at the end of Multimedia.displays, instead of deleting the GadflyDisplay at the end, so that folks who have put TerminalExtensions.jl in their startup can still use Gadfly in another type of terminal without error.

@bjarthur bjarthur merged commit 2cbd6d4 into GiovineItalia:master Mar 5, 2019
@bjarthur bjarthur deleted the bja/termext branch March 5, 2019 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

display()
2 participants