Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cache_data workflow to download from successfully cached artifacts #692

Merged
merged 2 commits into from
Nov 16, 2020
Merged

Update cache_data workflow to download from successfully cached artifacts #692

merged 2 commits into from
Nov 16, 2020

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Nov 16, 2020 •
edited
Loading

Description of proposed changes

Adds a missing @ back to cache workflow, accidental typo from #687. Also bumps dawidd6/action-download-artifact from 2.6.3 to 2.10.0 and make sure that we only grab from successfully cached artifacts next time (see dawidd6/action-download-artifact#35).

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Notes

  • You can write /format in the first line of a comment to lint the code automatically

@weiji14 weiji14 added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Nov 16, 2020
@weiji14 weiji14 changed the title Fix typo on cache_data workflow Update cache_data workflow to download from successfully cached artifacts Nov 16, 2020
@weiji14 weiji14 marked this pull request as ready for review November 16, 2020 00:56
@seisman seisman added this to the 0.2.2 milestone Nov 16, 2020
@weiji14 weiji14 merged commit ec4ce2f into master Nov 16, 2020
@weiji14 weiji14 deleted the update-workflow branch November 16, 2020 01:20
@seisman seisman modified the milestones: 0.2.2, 0.3.0 Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seisman seisman seisman approved these changes

Assignees
No one assigned
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@weiji14 @seisman