Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump setup-miniconda to v2.0.0 #687

Merged
merged 1 commit into from
Nov 9, 2020
Merged

Bump setup-miniconda to v2.0.0 #687

merged 1 commit into from
Nov 9, 2020

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Nov 9, 2020 •
edited
Loading

Bumps conda-incubator/setup-miniconda from v1 to v2.0.0.

Description of proposed changes

Notably, this resolves the following warning mentioned in conda-incubator/setup-miniconda#78:

Warning: The `add-path` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

Also changed repo name from goanpeca/setup-miniconda to conda-incubator/setup-miniconda and ensure we use "latest" miniconda-version to avoid these deprecation warnings:

Deprecation warnings

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Notes

  • You can write /format in the first line of a comment to lint the code automatically

@weiji14
Bump setup-miniconda to v2.0.0
983b1d1 
Bumps [conda-incubator/setup-miniconda](https://github.com/conda-incubator/setup-miniconda) from v1 to v2.0.0.
- [Release notes](https://github.com/conda-incubator/setup-miniconda/releases)
- [Commits](conda-incubator/setup-miniconda@v1...v2.0.0)

Also changed repo name from `goanpeca/setup-miniconda` to `conda-incubator/setup-miniconda` and ensure we use "latest" miniconda-version to avoid deprecation warnings.
@weiji14 weiji14 added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Nov 9, 2020
@weiji14 weiji14 marked this pull request as ready for review November 9, 2020 03:09
@seisman seisman added this to the 0.2.1 milestone Nov 9, 2020
@weiji14 weiji14 merged commit c7c5eae into master Nov 9, 2020
@weiji14 weiji14 deleted the setup-miniconda-2.0.0 branch November 9, 2020 03:45
@weiji14 weiji14 mentioned this pull request Nov 16, 2020
Merged
5 tasks
weiji14 added a commit that referenced this pull request Nov 16, 2020
@weiji14
Update cache_data workflow to download from successfully cached artif…
ec4ce2f 
…acts (#692)

Adds a missing @ back to cache workflow, accidental typo from #687.
Also bumps dawidd6/action-download-artifact from 2.6.3 to 2.10.0 and
make sure that we only grab from successfully cached artifacts next time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seisman seisman seisman approved these changes

Assignees
No one assigned
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Milestone
0.2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@weiji14 @seisman