Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Figure.meca 'offset' alias to match GMT 6.2.0rc1 syntax #1255

Merged
merged 3 commits into from
May 4, 2021

Conversation

seisman
Copy link
Member

@seisman seisman commented May 3, 2021

Description of proposed changes

meca in GMT <=6.1.1 used -C option for offset.
Since GenericMappingTools/gmt#4873, the -C option is used
to specify the CPT of the compressional part, and the old -C option is
renamed to -A, although it's still backward-compatible.

This PR changes the 'offset' alias from C to A, to match the GMT 6.2.0rc1
syntax.

Fixes #1094.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels May 3, 2021
@seisman seisman added this to the 0.4.0 milestone May 3, 2021
@seisman seisman requested a review from maxrjones May 3, 2021 19:59
@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label May 3, 2021
Copy link
Member

@michaelgrund michaelgrund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label May 4, 2021
@seisman seisman merged commit 454c682 into master May 4, 2021
@seisman seisman deleted the meca-parameter branch May 4, 2021 19:02
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
…icMappingTools#1255)

Change the "offset" alias from C to A, to match the GMT 6.2.0rc1 syntax.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect parameter in Figure.meca()
4 participants