if -R -J is given with -T then we must deal with them #3675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The inisital PR only called map_setup if RJ was required but in fact we must call map_setup if -R -J is given.
seisman
approved these changes
Jul 18, 2020
|
At issue are uses like this:
which implicitly requires map width (and map height for -Yc). So I am adding a check for that first. |
|
Tests pass for me locally with this change. Let's make sure it works for you or CI before we merge. |
|
I think this is still good go go, @seisman despite the late edit. Now, -Xc or -Yc will require -R -J. |
seisman
approved these changes
Jul 18, 2020
github-actions bot
pushed a commit
that referenced
this pull request
Jul 18, 2020
* if -R -J is given with -T then we must deal with them The inisital PR only called map_setup if RJ was required but in fact we must call map_setup if -R -J is given. * Update gmt_init.c
seisman
pushed a commit
that referenced
this pull request
Jul 18, 2020
* if -R -J is given with -T then we must deal with them The inisital PR only called map_setup if RJ was required but in fact we must call map_setup if -R -J is given. * Update gmt_init.c Co-authored-by: Paul Wessel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial PR #3672 only called gmt_map_setup if -R -J was required but in fact we must of course call gmt_map_setup if -R -J is given.