Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let psxy -T without -B skip the check for -R -J #3672

Merged
merged 3 commits into from
Jul 18, 2020
Merged

Let psxy -T without -B skip the check for -R -J #3672

merged 3 commits into from
Jul 18, 2020

Conversation

PaulWessel
Copy link
Member

Since no projection is needed to in this case (presumably to set -X -Y only) then we dont need to complain if -R -J are not set. This means a gmt psxy -T -X -Y call can be the first in a plot sequence without running afoul of no -R -J history.
This PR also adds documentation of -T to the classic section of psxy.

@PaulWessel
Let psxy -T without -B skip the check for -R -J
3ddb222 
Since no projection is needed to iin this case (presumably to set -X -Y only) then we dont need to complain if -R -J are not set.
@PaulWessel PaulWessel requested a review from seisman July 18, 2020 02:52
@seisman
Copy link
Member

seisman commented Jul 18, 2020

This PR doesn't work. gmt plot -T -X1c -Y1c is waiting for stdin input.

@PaulWessel
Copy link
Member Author

Yep, I only tested classic... SO in modern, we are trying to auto-determine the region from the data file... I will need to intervene in gmt_init_module based on -T. Stay tuned.

@PaulWessel
Copy link
Member Author

This works for me now:

gmt begin map
  gmt basemap -R0/4/0/4 -JX4i -B1
  gmt plot -T -X2i
  gmt basemap -R0/4/0/4 -JX4i -B1
 gmt end show

seisman
seisman approved these changes Jul 18, 2020
View reviewed changes
Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Backport to 6.1?

@PaulWessel PaulWessel added the backport 6.1 Backport this PR to 6.1 branch label Jul 18, 2020
@seisman seisman merged commit 5e13b22 into master Jul 18, 2020
@seisman seisman deleted the no-RJ-needed-with-T branch July 18, 2020 03:40
github-actions bot pushed a commit that referenced this pull request Jul 18, 2020
@PaulWessel @github-actions
Let psxy -T without -B skip the check for -R -J (#3672)
0048f9f 
Since no projection is needed to iin this case (presumably to set -X -Y only) then we dont need to complain if -R -J are not set.
@github-actions github-actions bot mentioned this pull request Jul 18, 2020
Merged
seisman pushed a commit that referenced this pull request Jul 18, 2020
@github-actions @PaulWessel
Let psxy -T without -B skip the check for -R -J (#3672) (#3674)
5606bd6 
Since no projection is needed to iin this case (presumably to set -X -Y only) then we dont need to complain if -R -J are not set.

Co-authored-by: Paul Wessel <[email protected]>
@seisman seisman mentioned this pull request Jul 18, 2020
Closed
@PaulWessel PaulWessel mentioned this pull request Jul 18, 2020
Merged
@joa-quim joa-quim mentioned this pull request Jul 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seisman seisman seisman approved these changes

Assignees
No one assigned
Labels
backport 6.1 Backport this PR to 6.1 branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PaulWessel @seisman