-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @jbrowse/react-app embedded component #3531
Conversation
51b2833
to
3fa78a1
Compare
3fa78a1
to
f52fc07
Compare
a419aed
to
159eaf9
Compare
6f03ae5
to
172eebb
Compare
Codecov Report
@@ Coverage Diff @@
## main #3531 +/- ##
==========================================
- Coverage 64.66% 64.30% -0.36%
==========================================
Files 945 961 +16
Lines 29786 29959 +173
Branches 7171 7190 +19
==========================================
+ Hits 19261 19266 +5
- Misses 10361 10529 +168
Partials 164 164
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
f100d9d
to
db445c4
Compare
we could consider merging this as-is, but mark it as private:true until ready to publish. I'll mark this as ready for review |
ed80094
to
a8608ab
Compare
now does not attempt to store session data in sessionStorage or localStorage, nor does it have undo/redo, or theme changing...could try to modularize those out into an optional mixins and document how to add them in a storybook but it may be reasonable default to leave our be default |
a8608ab
to
0c66bc7
Compare
0c66bc7
to
d1e609a
Compare
This is a proof of concept to show we can embed the whole jbrowse-web app as a react component, which I call @jbrowse/react-app
There are still many things that need improving, but it does work at a base level.
The storybook works as a good live demo of this. Most of the stories are not wired up to automatically load a particular view yet, but can be clicked anyways
https://jbrowse.org/storybook/app/main_webapp_component/
Right now, this essentially copies and pastes the entire jbrowse-web src directory, which is a fairly large code duplication, but as we have seen with desktop, it may be that embedded has significantly different needs than web, so having it separate (for now) could be ok