-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download range of transactions during syncing #1315
Comments
To clarify: by "range of blocks", I believe this means something more like "list of blocks", since block IDs are not continuous (versus block heights, which are continuous). In my current WIP, the new API takes in a vector of block IDs, rather than a range. |
It's up to us. We can request transactions by the range of block heights instead of block ids. On the blockchain level we don't have use cases for list of ids, its more API node kind functionality and maybe indexer will provide that. |
Related issues: - Closes #1315 - Closes #1089 This PR introduces a structure for holding data collections called `Batch`. A Batch encapsulates a collection of homogeneous data returned by a P2P request, retaining only successfully received items. A Batch may contain fewer items than originally requested, in which case an error has occurred. For transactions, we now use batches to request and return transaction data from peers. This means a reduced number of database trips and more succinct (less chatty) p2p communication. --------- Co-authored-by: xgreenx <[email protected]>
Related issues: - Closes FuelLabs/fuel-core#1315 - Closes FuelLabs/fuel-core#1089 This PR introduces a structure for holding data collections called `Batch`. A Batch encapsulates a collection of homogeneous data returned by a P2P request, retaining only successfully received items. A Batch may contain fewer items than originally requested, in which case an error has occurred. For transactions, we now use batches to request and return transaction data from peers. This means a reduced number of database trips and more succinct (less chatty) p2p communication. --------- Co-authored-by: xgreenx <[email protected]>
Related issues: - Closes FuelLabs/fuel-core#1315 - Closes FuelLabs/fuel-core#1089 This PR introduces a structure for holding data collections called `Batch`. A Batch encapsulates a collection of homogeneous data returned by a P2P request, retaining only successfully received items. A Batch may contain fewer items than originally requested, in which case an error has occurred. For transactions, we now use batches to request and return transaction data from peers. This means a reduced number of database trips and more succinct (less chatty) p2p communication. --------- Co-authored-by: xgreenx <[email protected]>
Ref #1133
Instead of fetching transactions per header, add a new p2p API that allows entire ranges of blocks to be downloaded from a peer.
The text was updated successfully, but these errors were encountered: