Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node Sync Throughput #1089

Closed
Voxelot opened this issue Mar 30, 2023 · 2 comments · Fixed by #1349
Closed

Node Sync Throughput #1089

Voxelot opened this issue Mar 30, 2023 · 2 comments · Fixed by #1349
Assignees
@bvrooman @MitchTurner

Comments

@Voxelot
Copy link
Member

Voxelot commented Mar 30, 2023 •
edited
Loading

@xgreenx noticed that it can take up to several hours to sync ~50k blocks. We need to investigate whether requests are sufficiently batched for downloading blocks and if the importer is being fully utilized at maximal capacity. If the importer is actually being kept busy during sync and it's just taking a long time, then we need to investigate further into gas metering discrepancies and if the min block time is too low.

We should aim to have a benchmark / loadtest to measure syncing time between nodes.
@Voxelot
Copy link
Member Author

Voxelot commented Apr 17, 2023

related #1133

@xgreenx
Copy link
Collaborator

xgreenx commented Apr 25, 2023 •
edited by bvrooman
Loading

@freesig freesig assigned freesig, xgreenx and ghost and unassigned ghost Apr 27, 2023
@xgreenx xgreenx mentioned this issue Oct 1, 2023
Merged
bvrooman pushed a commit that referenced this issue Oct 2, 2023
@xgreenx
feat: batch transactions import (#1349)
5d1a9a3 
Related issues:
- Closes #1315
- Closes #1089

This PR introduces a structure for holding data collections called
`Batch`. A Batch encapsulates a collection of homogeneous data returned
by a P2P request, retaining only successfully received items. A Batch
may contain fewer items than originally requested, in which case an
error has occurred.

For transactions, we now use batches to request and return transaction
data from peers. This means a reduced number of database trips and more
succinct (less chatty) p2p communication.

---------

Co-authored-by: xgreenx <[email protected]>
crypto523 pushed a commit to crypto523/fuel-core that referenced this issue Oct 7, 2024
@xgreenx
feat: batch transactions import (#1349)
182d03e 
Related issues:
- Closes FuelLabs/fuel-core#1315
- Closes FuelLabs/fuel-core#1089

This PR introduces a structure for holding data collections called
`Batch`. A Batch encapsulates a collection of homogeneous data returned
by a P2P request, retaining only successfully received items. A Batch
may contain fewer items than originally requested, in which case an
error has occurred.

For transactions, we now use batches to request and return transaction
data from peers. This means a reduced number of database trips and more
succinct (less chatty) p2p communication.

---------

Co-authored-by: xgreenx <[email protected]>
sui319 added a commit to sui319/fuel-core that referenced this issue Feb 17, 2025
@sui319 @xgreenx
feat: batch transactions import (#1349)
76eabc1 
Related issues:
- Closes FuelLabs/fuel-core#1315
- Closes FuelLabs/fuel-core#1089

This PR introduces a structure for holding data collections called
`Batch`. A Batch encapsulates a collection of homogeneous data returned
by a P2P request, retaining only successfully received items. A Batch
may contain fewer items than originally requested, in which case an
error has occurred.

For transactions, we now use batches to request and return transaction
data from peers. This means a reduced number of database trips and more
succinct (less chatty) p2p communication.

---------

Co-authored-by: xgreenx <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bvrooman bvrooman

@MitchTurner MitchTurner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: batch transactions import FuelLabs/fuel-core
5 participants
@Voxelot @bvrooman @freesig @MitchTurner @xgreenx