Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix watch page layout when theatre mode enabled and sidebar "hidden" #3931

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Fix watch page layout when theatre mode enabled and sidebar "hidden" #3931

merged 1 commit into from
Aug 30, 2023

Conversation

PikachuEXE
Copy link
Collaborator

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

Closes #3923

Description

See #3923

Screenshots

See #3923

Testing

See #3923
But remember to also test with Hide Recommended Videos OFF

Desktop

  • OS:
  • OS Version:
  • FreeTube version:

Additional context

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) August 23, 2023 01:20
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Aug 23, 2023
efb4f5ff-1298-471a-8973-3d47447115dc
efb4f5ff-1298-471a-8973-3d47447115dc approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kommunarr
kommunarr approved these changes Aug 30, 2023
View reviewed changes
Copy link
Collaborator

@kommunarr kommunarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FreeTubeBot FreeTubeBot merged commit 621cc27 into FreeTubeApp:development Aug 30, 2023
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Aug 30, 2023
@PikachuEXE PikachuEXE deleted the fix/Theatre-Hide-Recommended-style-issue branch August 30, 2023 03:20
absidue added a commit to absidue/FreeTube that referenced this pull request Aug 31, 2023
@absidue
Revert "! Fix watch page layout when theatre mode enabled and sidebar…
eb9076d 
… "hidden" (FreeTubeApp#3931)"

This reverts commit 621cc27.
@absidue absidue mentioned this pull request Aug 31, 2023
Merged
1 task
FreeTubeBot pushed a commit that referenced this pull request Sep 7, 2023
@absidue
Default theatre mode no sidebar (#3981)
e832f22 
* Revert "! Fix watch page layout when theatre mode enabled and sidebar "hidden" (#3931)"

This reverts commit 621cc27.

* Fix the watch page layout when the sidebar is hidden and theatre mode mode is enabled by default

* Do not use theatre mode while loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@ChunkyProgrammer ChunkyProgrammer ChunkyProgrammer approved these changes

@kommunarr kommunarr kommunarr approved these changes

@absidue absidue Awaiting requested review from absidue

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Dual column template used when theatre mod is enabled by default despite there being no sidebar
5 participants
@PikachuEXE @efb4f5ff-1298-471a-8973-3d47447115dc @ChunkyProgrammer @kommunarr @FreeTubeBot