Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Dual column template used when theatre mod is enabled by default despite there being no sidebar #3923

Closed
6 tasks done
Aiz0 opened this issue Aug 22, 2023 · 0 comments · Fixed by #3931 or #3981
Closed
6 tasks done
Labels

Comments

@Aiz0
Copy link
Contributor

Aiz0 commented Aug 22, 2023

Guidelines

  • I have encountered this bug in the latest release of FreeTube.
  • I have encountered this bug in the official downloads of FreeTube.
  • I have searched the issue tracker for open and closed issues that are similar to the bug report I want to file, without success.
  • I have searched the documentation for information that matches the description of the bug I want to file, without success.
  • This issue contains only one bug.

Describe the bug

  1. Ensure the Player Setting "Enable Theatre Mode by Default" is disabled.
    2023-08-22_T07:23:09
  2. Ensure the Distraction free Setting "Hide Recommended Videos" is enabled.
    2023-08-22_T07:25:06
  3. Go to any video without any other Sidebar items.
  4. Ensure that the single column template is used.
  5. Go back to settings and enable "Enable Theatre Mode by Default".
    2023-08-22_T07:27:22
  6. Go back to that same video.
  7. See that Dual column mode is used despite there being no sidebar items.
    2023-08-22_T07:30:09

Expected Behavior

When theatre mode is enabled by default it's adds the class useTheatreMode to the VideoLayout even when toggling theatre mode is impossible
2023-08-22_T07:31:21

The class useTheatreMode should either not be present or not overide the noSidebar class.

Issue Labels

visual bug

FreeTube Version

v0.19.0 Beta 21bf608

Operating System Version

Arch Linux

Installation Method

AUR

Primary API used

Local API

Last Known Working FreeTube Version (If Any)

No response

Additional Information

Related #916

Nightly Build

@Aiz0 Aiz0 added the bug Something isn't working label Aug 22, 2023
@Aiz0 Aiz0 changed the title [Bug]: Dual column template used when theatre mod is enabled by default despite there being no sidebar items [Bug]: Dual column template used when theatre mod is enabled by default despite there being no sidebar Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants