handle libraries (other than taipy) in HTML renderer (Avaiga#1000)

* handle libraries (other than taipy) in HTML renderer * fix tests * format --------- Co-authored-by: Fred Lefévère-Laoide <[email protected]>
FredLL-Avaiga · Oct 25, 2023 · 74a581f · 74a581f
1 parent 738021b
commit 74a581f
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/src/taipy/gui/_renderers/_html/factory.py b/src/taipy/gui/_renderers/_html/factory.py
@@ -19,5 +19,5 @@ class _HtmlFactory(_Factory):
     def create_element(gui, namespace: str, control_type: str, all_properties: t.Dict[str, str]) -> t.Tuple[str, str]:
         builder_html = _Factory.call_builder(gui, f"{namespace}.{control_type}", all_properties, True)
         if builder_html is None:
-            return f"<div>INVALID SYNTAX - Control is '{namespace}:{control_type}'", "div"
+            return f"<div>INVALID SYNTAX - Control is '{namespace}:{control_type}'</div>", "div"
         return builder_html  # type: ignore
diff --git a/src/taipy/gui/_renderers/_html/parser.py b/src/taipy/gui/_renderers/_html/parser.py
@@ -93,7 +93,7 @@ def append_data(self, data: str) -> None:
     def parse_taipy_tag(self) -> None:
         tp_string, tp_element_name = self.taipy_tag.parse(self._gui)
         self.append_data(tp_string)
-        self.tag_mapping[f"taipy:{self.taipy_tag.control_type}"] = tp_element_name
+        self.tag_mapping[f"{self.taipy_tag.namespace}:{self.taipy_tag.control_type}"] = tp_element_name
         self.taipy_tag = None
 
     def get_jsx(self) -> str:

diff --git a/tests/taipy/gui/extension/test_library.py b/tests/taipy/gui/extension/test_library.py
@@ -135,20 +135,22 @@ def test_lib_input_html_1(gui: Gui, test_client, helpers):
         'defaultValue=""',
         "broadcast={_bc_broadcast}",
         "value={tpec_TpExPr_val_TPMDL_0}",
+        "</TestLib_Input>",
     ]
     helpers.test_control_html(gui, html_string, expected_list)
 
 
 def test_lib_input_html_2(gui: Gui, test_client, helpers):
     val = ""  # noqa: F841
     gui._set_frame(inspect.currentframe())
-    html_string = '<test_lib:testinput multiline="true">{val}</testlib:testinput>'
+    html_string = '<test_lib:testinput multiline="true">{val}</test_lib:testinput>'
     expected_list = [
         "<TestLib_Input",
         "multiline={true}",
         'defaultValue=""',
         "broadcast={_bc_broadcast}",
         "value={tpec_TpExPr_val_TPMDL_0}",
+        "</TestLib_Input>",
     ]
     helpers.test_control_html(gui, html_string, expected_list)