Skip to content
This repository has been archived by the owner on Feb 15, 2024. It is now read-only.

handle libraries (other than taipy) in HTML renderer #1000

Merged
merged 3 commits into from
Oct 25, 2023
Merged

handle libraries (other than taipy) in HTML renderer #1000

merged 3 commits into from
Oct 25, 2023

Conversation

FredLL-Avaiga
Copy link
Member

support for

<h1>Scenario html</h1>
<taipy_gui_core:scenario_selector>{scenario}</taipy_gui_core:scenario_selector>
<taipy_gui_core:scenario>{scenario}</taipy_gui_core:scenario>
<taipy_gui_core:scenario_dag width="100%">{scenario}</taipy_gui_core:scenario_dag>

@FredLL-Avaiga FredLL-Avaiga added 🟥 Priority: Critical Must be fixed ASAP Gui: Back-End Related to the back-end side of Taipy GUI. 💥Malfunction Addresses an identified problem. 📝Release Notes Impacts the Release Notes labels Oct 25, 2023
@FredLL-Avaiga FredLL-Avaiga self-assigned this Oct 25, 2023
dinhlongviolin1
dinhlongviolin1 approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@dinhlongviolin1 dinhlongviolin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

FabienLelaquais
FabienLelaquais approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions
Copy link

github-actions bot commented Oct 25, 2023 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
5191 4484 86% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
src/taipy/gui/_renderers/_html/factory.py 89% 🟢
src/taipy/gui/_renderers/_html/parser.py 93% 🟢
TOTAL 91% 🟢

updated for commit: e436dc6 by action🐍

@github-actions
Copy link

github-actions bot commented Oct 25, 2023 •
edited
Loading

Coverage report for gui

St.❔
 Category Percentage Covered / Total
🟢 Statements 80.48% 2227/2767
🟡 Branches 61.84% 1345/2175
🟡 Functions 74.81% 389/520
🟢 Lines 80.85% 2065/2554

Test suite run success

317 tests passing in 35 suites.

Report generated by 🧪jest coverage report action from e436dc6

Fred Lefévère-Laoide added 2 commits October 25, 2023 15:57
@FredLL-Avaiga FredLL-Avaiga merged commit 74a581f into develop Oct 25, 2023
@FredLL-Avaiga FredLL-Avaiga deleted the bug/html-page-with-library-component branch October 25, 2023 14:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dinhlongviolin1 dinhlongviolin1 dinhlongviolin1 approved these changes

@FabienLelaquais FabienLelaquais FabienLelaquais approved these changes

Assignees

@FredLL-Avaiga FredLL-Avaiga

Labels
Gui: Back-End Related to the back-end side of Taipy GUI. 💥Malfunction Addresses an identified problem. 🟥 Priority: Critical Must be fixed ASAP 📝Release Notes Impacts the Release Notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FredLL-Avaiga @dinhlongviolin1 @FabienLelaquais