svelte plugin: refactor tests, document new format, clean up config loading #1304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pikapkg/snowpack/5fzilkk48 |
FredKSchott
force-pushed
the
svelte-cleanup-options
branch
from
9a014b6 to
006e7b5
Compare
FredKSchott
commented
Oct 14, 2020
| You can pass Svelte HMR specific options through the `hot` option of the plugin. Here are the available options and their defaults: | ||
|
|
||
| ```js | ||
| { |
There was a problem hiding this comment.
this didn't appear to be relevant, replaced with a link to the svelte-hmr main repo documentation
FredKSchott
commented
Oct 14, 2020
|
|
||
| if (pluginOptions.compileOptions !== undefined) { | ||
| throw new Error( | ||
| `[plugin-svelte] Could not recognize "compileOptions". Did you mean "compilerOptions"?`, |
There was a problem hiding this comment.
😅 only because I did this and didn't realize it
drwpow
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @Rich-Harris
Changes
Testing
Docs