normalize svelte.config.js format #1303
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Currently,
@snowpack/plugin-svelte
will read configuration from a svelte.config.js file assuming the following structure:Unfortunately, this makes it impossible to add any config other than compiler options. For example, in the Snowpack/Svelte integration we're working on, it's necessary to specify an
adapter
to process the build output, and if we can't do so in svelte.config.js then we would have to introduce a new config file.This PR changes the plugin behaviour to be in line with the format articulated here, which we're encouraging all members of the ecosystem to adopt:
Unfortunately, I don't think there's a way to do this as a non-breaking change. (It should affect very few people, since most people only use svelte.config.js to specify
preprocess
, the behaviour of which is unchanged.)Testing
Tested with a local project. There aren't any automated tests that currently cover this aspect of the plugin's behaviour.
Docs
The current expected svelte.config.js structure isn't documented anywhere, so this PR doesn't change anything.