Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not assume a build script failed completely if there's stderr #1255

Merged
merged 2 commits into from
Oct 8, 2020
Merged

Conversation

fubhy
Copy link
Contributor

@fubhy fubhy commented Oct 8, 2020

Using experimental features in tailwindcss currently causes build failures in the snowpack-build-script plugin because it considers any stderr output as a critical failure of the script.

I've also opened an issue on the tailwind repository: tailwindlabs/tailwindcss#2522

@fubhy fubhy requested a review from a team as a code owner October 8, 2020 15:52
@vercel
Copy link

vercel bot commented Oct 8, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/snowpack/loz00bdu7
✅ Preview: https://snowpack-git-master.pikapkg.vercel.app

@fubhy
Copy link
Contributor Author

fubhy commented Oct 8, 2020

This pull request logs stderr & stdout but changes the error handling behavior so that only exitCode != 0 is considered an actual failure. This gives the underlying scripts some wiggle room for where they log their output (console.warn is an alias for console.error so it logs into stderr). I think tailwind shouldn't use console.warn but also snowpack shouldn't consider stderr to be a critical failure (checking the exit code should be sufficient).

@fubhy
Copy link
Contributor Author

fubhy commented Oct 8, 2020

@FredKSchott I updated the PR accordingly.

@FredKSchott
Copy link
Owner

LGTM! Errors seem unrelated, will dig into those seperately

@FredKSchott FredKSchott merged commit 1ef62f0 into FredKSchott:master Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants