Skip to content

Commit

Permalink
fix: do not assume a build script failed completely if there's stderr (
Browse files Browse the repository at this point in the history
…#1255)

* fix: do not assume a build script failed completely if there's stderr output

* refactor: address pr review comments
  • Loading branch information
fubhy authored Oct 8, 2020
1 parent 899dd10 commit 1ef62f0
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions plugins/plugin-build-script/plugin.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@ function buildScriptPlugin(_, {input, output, cmd}) {
if (exitCode !== 0) {
throw new Error(stderr || stdout);
}
// If the plugin output tp stderr, how it to the user.
// If the plugin outputs to stderr, show it to the user.
if (stderr) {
throw new Error(stderr);
console.warn(stderr);
}
return {[output[0]]: stdout};
},
Expand Down

1 comment on commit 1ef62f0

@vercel
Copy link

@vercel vercel bot commented on 1ef62f0 Oct 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.