Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop the call to getBetas in getAppData #9768

Merged
merged 1 commit into from
Jul 12, 2022
Merged

Stop the call to getBetas in getAppData #9768

merged 1 commit into from
Jul 12, 2022

Conversation

yuwenmemon
Copy link
Contributor

@luacmartins please review

HOLD ON https://github.com/Expensify/Web-Expensify/pull/34251 DEPLOYED TO PRODUCTION

Details

Stop calling getBetas in getAppData, since we are now returning that info via the OpenApp command

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/213881

Tests

  1. Login via an expensifail.com account, make sure that you can see the #expensifail.com domain room.
  2. Login via a vanilla Gmail account, make sure that you cannot see any default rooms (make sure you have not created a workspace, but have created a policy on OldDot that you are a member of)

@yuwenmemon yuwenmemon requested a review from luacmartins July 7, 2022 20:54
@yuwenmemon yuwenmemon requested a review from a team as a code owner July 7, 2022 20:54
@yuwenmemon yuwenmemon self-assigned this Jul 7, 2022
@melvin-bot melvin-bot bot requested review from stitesExpensify and removed request for a team July 7, 2022 20:54
@luacmartins luacmartins changed the title [HOLD WEB#34251] Stop the call to getBetas in getAppData Stop the call to getBetas in getAppData Jul 12, 2022
@luacmartins
Copy link
Contributor

https://github.com/Expensify/Web-Expensify/pull/34251 is in prod. Removing hold and merging!

@luacmartins luacmartins merged commit 61f7d4b into main Jul 12, 2022
@luacmartins luacmartins deleted the yuwen-stopBetaLoading branch July 12, 2022 20:04
@OSBotify OSBotify mentioned this pull request Jul 12, 2022
Closed
95 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @luacmartins in version: 1.1.83-2 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@kbecciv kbecciv mentioned this pull request Jul 14, 2022
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @chiragsalian in version: 1.1.84-13 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@marcaaron marcaaron mentioned this pull request Jul 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luacmartins luacmartins luacmartins approved these changes

@stitesExpensify stitesExpensify stitesExpensify approved these changes

Assignees

@yuwenmemon yuwenmemon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yuwenmemon @luacmartins @OSBotify @stitesExpensify