-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HybridApp] Receive structured initialProperties
(not as url) and improve url handling
#56463
Closed
war-in
wants to merge
544
commits into
Expensify:main
from
software-mansion-labs:war-in/send-init-props-as-object
Closed
[HybridApp] Receive structured initialProperties
(not as url) and improve url handling
#56463
war-in
wants to merge
544
commits into
Expensify:main
from
software-mansion-labs:war-in/send-init-props-as-object
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/libs/actions/Travel.ts
mateuuszzzzz
reviewed
Feb 6, 2025
mateuuszzzzz
reviewed
Feb 6, 2025
mateuuszzzzz
reviewed
Feb 6, 2025
…-shows-not-here-page Refactor shouldFetchReport function to reduce updates
…-amount-is-misaligned Fix per diem amount is wrapped into multiple lines
[No QA] Remove @main to prevent hidden fetch and checkout
fix: when selecting categories, the selected categories get reset - v2
[NO QA] Add files via upload
…519-fix-filter-cards Do not return empty card Objects for AdvancedFilters
fix: New message marker is not displayed when the chat opened offline
Follow up update display name
…k/wrap-when-name-too-long Make the name wrapped when it's too long
…r-font-height-being-smaller-on-first-render Fix composer font height being smaller on first render
…/feat/55007-update-educational-tooltip [No QA] [Manager McTest] Update our exisitingEducationalTooltip component to display the new buttons (Try it out/No thanks)
…er-mctest-as-recipient-for-eligible-users Show Manager McTest as recipient for eligible users
…appears-below-composer Fix tooltip appears below the composer when going back from another page
…on-submit-button Fix - show loading on submit button after expense creation confirmed
…' into war-in/send-init-props-as-object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop