Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update copy for companyStep.subtitle #5598

Merged
merged 2 commits into from
Oct 1, 2021
Merged

Conversation

flodnv
Copy link
Contributor

@flodnv flodnv commented Sep 30, 2021

Details

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/179252

Tests

  1. Start setting up a workspace
  2. Verify the copy changed

Screen Shot 2021-09-30 at 12 54 54 PM

QA Steps

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android
    Since this is a copy change only, I would say not testing on all platforms is fine...?

Screenshots

Web

Screen Shot 2021-09-30 at 12 54 54 PM

Mobile Web

Desktop

iOS

Android

@flodnv flodnv requested a review from a team September 30, 2021 11:58
@flodnv flodnv self-assigned this Sep 30, 2021
@MelvinBot MelvinBot requested review from MariaHCD and removed request for a team September 30, 2021 11:58
@flodnv
Copy link
Contributor Author

flodnv commented Sep 30, 2021

The HOLD is for the Spanish translation, I asked here

@flodnv flodnv requested a review from a team as a code owner September 30, 2021 13:57
@flodnv flodnv changed the title [HOLD es] Update copy for companyStep.subtitle Update copy for companyStep.subtitle Sep 30, 2021
@flodnv
Copy link
Contributor Author

flodnv commented Sep 30, 2021

Off hold!

@flodnv flodnv removed the request for review from a team September 30, 2021 13:57
@MonilBhavsar MonilBhavsar merged commit 776b4e9 into main Oct 1, 2021
@MonilBhavsar MonilBhavsar deleted the flo_companyStepCopy branch October 1, 2021 06:44
@OSBotify
Copy link
Contributor

OSBotify commented Oct 1, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Oct 4, 2021

🚀 Deployed to staging by @MonilBhavsar in version: 1.1.4-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Oct 6, 2021

🚀 Deployed to production by @chiragsalian in version: 1.1.5-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants