Deploy Checklist: New Expensify 2021-10-04

[OSBotify]

Release Version: 1.1.5-1
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Create new Payment ButtonWithMenu and add it to the Confirm Page #3866
• New page: Add a Debit Card #4405
• Highlight all errors in VBA flow - Personal information and Additional information steps #5259
• Fix endless spinner on "Send link" cause by not unpausing the request queue #5404
• Make entire workspace avatar clickable #5559
• Update copy for companyStep.subtitle #5598
• Update birth date validity checks #5615
• Fix wallet permission parentheses #5616
• [No QA] Add clarification notes on datepicker #5627
• [CP Stg] Add Venmo only if sending money #5661

Deploy Blockers:

• Update Add Debit Card page to use VBA styles and fix misaligned state/zip fields #5644
• Android - Venmo - Button has dropdown menu with options in the final confirmation page #5655
• Birth date selector - Adding a really old date (>150 years) gives incorrect error  #5667

cc @Expensify/applauseleads

[isagoico]

Starting QA!

[isagoico]

Regression is finished!
Issues found today:

1. VBA flow - Error message for very old birth date is not inline instead appears at the bottom of the page #5645 - Not sure if it's failing Update birth date validity checks #5615 @flodnv could you review this please 🙇
2. Update Add Debit Card page to use VBA styles and fix misaligned state/zip fields #5644 visual issue found while executing New page: Add a Debit Card #4405

Thanks!

[flodnv]

1. Ah! This should be solved when https://github.com/Expensify/Web-Secure/pull/2060 gets deployed to production which should be within a few hours!

[isagoico]

We had a big doubt with this issue #5655 on if it was expected behaviour or not. I think that there should not be an option to pay when requesting money. We added the deploy blocker label since this is not reproducible in production. CC @nickmurray47 (tagging you since you worked on #3866)

[nickmurray47]

Taking a look - that is not the expected behavior.

[nickmurray47]

I have a PR #5661 in review that should fix the issue once deployed to Staging

[isagoico]

Checking off #5661 (comment) and #5655

[isagoico]

Checking off #4405 context here: https://expensify.slack.com/archives/C9YU7BX5M/p1633462588128700

[isagoico]

Update on #5615 (comment). It's currently failing since it's throwing the wrong error when entering a really old age.

[roryabraham]

Demoting #5667 from deploy blocker and checked it off the list because it's an extreme edge case that we don't need to address with urgency. Also checked off #5615 because we don't need to block deploy on this.

@chiragsalian I think you should be good to whenever you're ready 🚀

[chiragsalian]