Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset completedTaskReportActionID to undefined so it's not passed to the backend when not used #51992

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Reset completedTaskReportActionID to undefined so it's not passed to the backend when not used #51992

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libs/actions/Report.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3505,7 +3505,7 @@ function completeOnboarding(
parentReportActionID: taskReportAction.reportAction.reportActionID,
assigneeChatReportID: '',
createdTaskReportActionID: taskCreatedAction.reportActionID,
completedTaskReportActionID: completedTaskReportAction?.reportActionID ?? '-1',
completedTaskReportActionID: completedTaskReportAction?.reportActionID ?? undefined,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @francoisl This change is causing "402 Invalid task data, missing completedTaskReportActionID" error on the latest main while selecting the "Chat and split expenses with friends" onboarding option and completing the flow. Reverting the change back to '-1' does fix it.

Screenshot 2024-11-05 at 5 06 06 in the morning

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is a video

onboarding-error.mp4

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that's why the PR description says:

Note that this requires the backend change https://github.com/Expensify/Auth/pull/13028 in order not to reintroduce the same issue from #51395

That first internal PR hasn't been deployed yet. The issue will resolve itself once we deploy it.

Copy link
Contributor

@HezekielT HezekielT Nov 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see. I didn't fully read the description. Thanks for the explanation.

Copy link
Contributor Author

@francoisl francoisl Nov 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries haha. If it's blocking you from testing something, feel free to temporarily revert that change back to -1 locally, but please don't commit it.
I expect that the backend changes should be deployed in the next 12 hours.

title: currentTask.reportName ?? '',
description: taskDescription ?? '',
}));
Expand Down
Loading