Reset `completedTaskReportActionID` to `undefined` so it's not passed to the backend when not used #51992

francoisl · 2024-11-04T21:00:55Z

Explanation of Change

Don't pass a completedTaskReportActionID in the payload to the command CompleteGuidedSetup for tasks that should not be created completed. This will prevent the backend from attempting to auto-complete tasks with the ID -1 (or '0' or whatever value we would use)

Note that this requires the backend change https://github.com/Expensify/Auth/pull/13028 in order not to reintroduce the same issue from #51395

Fixed Issues

Needed for https://github.com/Expensify/Expensify/issues/441575
Needed for #51969
Needed for #51980

Tests

Create a new account
Open your developer console
In the onboarding modal, select the option "Chat and split expenses with friends"
In the network tab of your dev console, make sure the payload for CompleteGuidedSetup doesn't include any completedTaskReportActionID
Make sure the response is a 200
Make sure all tasks in the Concierge chat are not checked
Create a chat with someone
Make sure the task "Start a chat" gets checked automatically

Verify that no errors appear in the JS console

QA steps

Create a new account
In the onboarding modal, select the option "Chat and split expenses with friends"
Make sure all tasks in the Concierge chat are not checked
Create a chat with someone
Make sure the task "Start a chat" gets checked automatically
Manually mark any other task as completed
Make sure you don't get any error such as "You don't have permission to take the requested action." or anything else

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

… to the backend when not used

melvin-bot · 2024-11-04T21:18:49Z

@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

danieldoglas · 2024-11-04T21:53:49Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

HezekielT · 2024-11-05T02:20:24Z

src/libs/actions/Report.ts

@@ -3505,7 +3505,7 @@ function completeOnboarding(
        parentReportActionID: taskReportAction.reportAction.reportActionID,
        assigneeChatReportID: '',
        createdTaskReportActionID: taskCreatedAction.reportActionID,
-        completedTaskReportActionID: completedTaskReportAction?.reportActionID ?? '-1',
+        completedTaskReportActionID: completedTaskReportAction?.reportActionID ?? undefined,


Hi @francoisl This change is causing "402 Invalid task data, missing completedTaskReportActionID" error on the latest main while selecting the "Chat and split expenses with friends" onboarding option and completing the flow. Reverting the change back to '-1' does fix it.

Here is a video

onboarding-error.mp4

Yep, that's why the PR description says:

Note that this requires the backend change https://github.com/Expensify/Auth/pull/13028 in order not to reintroduce the same issue from #51395

That first internal PR hasn't been deployed yet. The issue will resolve itself once we deploy it.

Oh, I see. I didn't fully read the description. Thanks for the explanation.

No worries haha. If it's blocking you from testing something, feel free to temporarily revert that change back to -1 locally, but please don't commit it.
I expect that the backend changes should be deployed in the next 12 hours.

Beamanator · 2024-11-05T08:08:39Z

Taking CP Staging out of title b/c these changes already got to staging in #51983 somehow, which has the exact same change 🤷

github-actions · 2024-11-06T00:38:19Z

🚀 Deployed to staging by https://github.com/danieldoglas in version: 9.0.58-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-11-07T12:43:22Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.58-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄	skipped 🚫

Reset completedTaskReportActionID to undefined so it's not passed…

77b483c

… to the backend when not used

francoisl changed the title ~~[CP Staging] Reset completedTaskReportActionID to undefined so it's not passed…~~ [CP Staging] Reset completedTaskReportActionID to undefined so it's not passed to the backend when not used Nov 4, 2024

francoisl self-assigned this Nov 4, 2024

francoisl requested a review from danieldoglas November 4, 2024 21:18

francoisl marked this pull request as ready for review November 4, 2024 21:18

francoisl requested a review from a team as a code owner November 4, 2024 21:18

melvin-bot bot removed the request for review from a team November 4, 2024 21:18

danieldoglas approved these changes Nov 4, 2024

View reviewed changes

danieldoglas merged commit 76552d6 into main Nov 4, 2024
20 checks passed

danieldoglas deleted the francois-dont-pass-unused-completedTaskReportActionID branch November 4, 2024 21:54

HezekielT reviewed Nov 5, 2024

View reviewed changes

Beamanator changed the title ~~[CP Staging] Reset completedTaskReportActionID to undefined so it's not passed to the backend when not used~~ Reset completedTaskReportActionID to undefined so it's not passed to the backend when not used Nov 5, 2024

github-actions bot mentioned this pull request Nov 5, 2024

Deploy Checklist: New Expensify 2024-11-05 #52084

Closed

71 tasks

NJ-2020 mentioned this pull request Nov 14, 2024

[HOLD for payment 2024-11-13] [$250] Desktop - Unexpected error when try to select the purpose "Chat and split" #51395

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reset `completedTaskReportActionID` to `undefined` so it's not passed to the backend when not used #51992

Reset `completedTaskReportActionID` to `undefined` so it's not passed to the backend when not used #51992

francoisl commented Nov 4, 2024 •

edited

Loading

melvin-bot bot commented Nov 4, 2024

danieldoglas commented Nov 4, 2024 •

edited

Loading

HezekielT Nov 5, 2024

HezekielT Nov 5, 2024

francoisl Nov 5, 2024

HezekielT Nov 5, 2024 •

edited

Loading

francoisl Nov 5, 2024 •

edited

Loading

Beamanator commented Nov 5, 2024

github-actions bot commented Nov 6, 2024

github-actions bot commented Nov 7, 2024

Reset completedTaskReportActionID to undefined so it's not passed to the backend when not used #51992

Reset completedTaskReportActionID to undefined so it's not passed to the backend when not used #51992

Conversation

francoisl commented Nov 4, 2024 • edited Loading

Explanation of Change

Fixed Issues

Tests

QA steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Nov 4, 2024

danieldoglas commented Nov 4, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

HezekielT Nov 5, 2024

Choose a reason for hiding this comment

HezekielT Nov 5, 2024

Choose a reason for hiding this comment

francoisl Nov 5, 2024

Choose a reason for hiding this comment

HezekielT Nov 5, 2024 • edited Loading

Choose a reason for hiding this comment

francoisl Nov 5, 2024 • edited Loading

Choose a reason for hiding this comment

Beamanator commented Nov 5, 2024

github-actions bot commented Nov 6, 2024

github-actions bot commented Nov 7, 2024

Reset `completedTaskReportActionID` to `undefined` so it's not passed to the backend when not used #51992

Reset `completedTaskReportActionID` to `undefined` so it's not passed to the backend when not used #51992

francoisl commented Nov 4, 2024 •

edited

Loading

danieldoglas commented Nov 4, 2024 •

edited

Loading

HezekielT Nov 5, 2024 •

edited

Loading

francoisl Nov 5, 2024 •

edited

Loading