fix: report fields are not disabled after disconnect accounting integration #51717

mkzie2 · 2024-10-30T08:07:00Z

Explanation of Change

If connected to an accounting integration that is allowed on the collect workspace - report fields are enabled. When disconnecting - report fields should be removed.

Fixed Issues

$ #50472
PROPOSAL: #50472 (comment)

Tests

Create a Collect workspace
Enable Accounting > Connect QBO
Go offline
Disconnect QBO
Verify Report fields are disabled
Go online
Verify Report fields are disabled

Verify that no errors appear in the JS console

Offline tests

See Tests

QA Steps

See Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-12-25.at.16.25.10-compressed.mov

Android: mWeb Chrome

Screen.Recording.2024-12-25.at.16.22.47-compressed.mov

iOS: Native

Screen.Recording.2024-12-25.at.16.15.36-compressed.mov

iOS: mWeb Safari

Screen.Recording.2024-12-25.at.16.18.11-compressed.mov

MacOS: Chrome / Safari

Screen.Recording.2024-12-25.at.16.09.40-compressed.mov

MacOS: Desktop

Screen.Recording.2024-12-25.at.16.12.47-compressed.mov

…ration

src/libs/PolicyUtils.ts

…e/50472

allgandalf · 2024-11-25T06:22:47Z

Still held

allgandalf · 2024-12-02T09:48:31Z

@mkzie2 jest is failing, please take a look

…e/50472

melvin-bot · 2024-12-25T09:30:01Z

@allgandalf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/libs/actions/connections/index.ts

Co-authored-by: Gandalf <[email protected]>

mkzie2 · 2024-12-27T07:27:44Z

@allgandalf Updated.

allgandalf · 2024-12-30T19:14:17Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Screen.Recording.2025-01-17.at.11.23.05.AM.mov

iOS: mWeb Safari

Screen.Recording.2025-01-17.at.11.25.54.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-01-17.at.10.35.09.AM.mov

Screen.Recording.2025-01-17.at.10.38.02.AM.mov

MacOS: Desktop

Screen.Recording.2025-01-17.at.10.42.25.AM.mov

allgandalf · 2025-01-07T10:18:22Z

PR is failing:

Screen.Recording.2025-01-07.at.3.47.40.PM.mov

allgandalf · 2025-01-09T05:12:18Z

bump @mkzie2

…e/50472

mkzie2 · 2025-01-09T09:14:52Z

@allgandalf Still working fine. Note that this only works in COLLECT workspaces. You were testing in CONTROL.

Screen.Recording.2025-01-09.at.16.12.40-compressed.mov

allgandalf · 2025-01-14T05:30:10Z

@mkzie2 PR is still failing for me, you can see the video, the policy is indeed collect:

Screen.Recording.2025-01-14.at.10.58.23.AM.mov

mkzie2 · 2025-01-14T08:15:42Z

@allgandalf Why were you testing on staging?

allgandalf · 2025-01-14T08:17:09Z

crap, i attached the wrong video i guess, wait i’ll post the right one

allgandalf · 2025-01-15T05:41:21Z

@mkzie2 can you merge main please, the branch is way outdated, just to be on safer side

…e/50472

…to mkzie2-issue/50472

mkzie2 · 2025-01-15T11:57:44Z

@allgandalf Merged.

mkzie2 · 2025-01-17T04:04:42Z

Bump @allgandalf

allgandalf · 2025-01-17T04:45:11Z

thanks, went out of my head, reviewing now

allgandalf · 2025-01-17T06:35:57Z

PR is failing for android native:

Screen.Recording.2025-01-17.at.12.00.49.PM.mov

PR is failing for android web:

Screen.Recording.2025-01-17.at.12.05.12.PM.mov

mkzie2 · 2025-01-17T07:04:11Z

@allgandalf Why are you testing on CONTROL workspace again? #51717 (comment). I know that because Rules feature is exclusive to CONTROL.

allgandalf · 2025-01-17T08:06:07Z

I know that because Rules feature is exclusive to CONTROL.

umm, idk how that happened, because if you see other videos, i use the same workspace

dangrous

LGTM!

OSBotify · 2025-01-21T16:30:56Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-01-23T18:26:50Z

🚀 Deployed to staging by https://github.com/dangrous in version: 9.0.89-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-01-28T01:50:15Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.89-8 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

fix: report fields are not disabled after disconnect accounting integ…

059083b

…ration

mkzie2 changed the title ~~fix: report fields are not disabled after disconnect accounting integration~~ [HOLD BE] fix: report fields are not disabled after disconnect accounting integration Oct 30, 2024

allgandalf reviewed Oct 30, 2024

View reviewed changes

src/libs/PolicyUtils.ts Outdated Show resolved Hide resolved

Merge branch 'main' of https://github.com/mkzie2/App into mkzie2-issu…

c5b9b83

…e/50472

Merge branch 'main' of https://github.com/mkzie2/App into mkzie2-issu…

baeedbf

…e/50472

mkzie2 changed the title ~~[HOLD BE] fix: report fields are not disabled after disconnect accounting integration~~ fix: report fields are not disabled after disconnect accounting integration Dec 24, 2024

mkzie2 added 2 commits December 25, 2024 15:45

Merge branch 'main' of https://github.com/mkzie2/App into mkzie2-issu…

99c4c61

…e/50472

use constants

b38b67b

mkzie2 marked this pull request as ready for review December 25, 2024 09:29

mkzie2 requested a review from a team as a code owner December 25, 2024 09:29

melvin-bot bot requested review from allgandalf and removed request for a team December 25, 2024 09:29

allgandalf reviewed Dec 25, 2024

View reviewed changes

src/libs/actions/connections/index.ts Outdated Show resolved Hide resolved

mkzie2 and others added 3 commits December 27, 2024 14:13

Update src/libs/actions/connections/index.ts

ce41955

Co-authored-by: Gandalf <[email protected]>

Merge branch 'main' into mkzie2-issue/50472

2526a80

fix lint

eebb7c6

mkzie2 mentioned this pull request Dec 30, 2024

[HOLD for payment 2025-02-04] [$250] Report fields - Feature can be enabled in collect workspace #50472

Open

6 tasks

merge main

39d63b1

Merge branch 'main' of https://github.com/mkzie2/App into mkzie2-issu…

9fdb368

…e/50472

mkzie2 added 2 commits January 15, 2025 18:57

Merge branch 'main' of https://github.com/mkzie2/App into mkzie2-issu…

0147b07

…e/50472

Merge branch 'mkzie2-issue/50472' of https://github.com/mkzie2/App in…

35696e7

…to mkzie2-issue/50472

allgandalf approved these changes Jan 21, 2025

View reviewed changes

melvin-bot bot requested a review from dangrous January 21, 2025 07:15

dangrous approved these changes Jan 21, 2025

View reviewed changes

dangrous merged commit d91e4b6 into Expensify:main Jan 21, 2025
17 checks passed

github-actions bot mentioned this pull request Jan 23, 2025

Deploy Checklist: New Expensify 2025-01-23 #55657

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: report fields are not disabled after disconnect accounting integration #51717

fix: report fields are not disabled after disconnect accounting integration #51717

mkzie2 commented Oct 30, 2024 •

edited

Loading

allgandalf commented Nov 25, 2024

allgandalf commented Dec 2, 2024

melvin-bot bot commented Dec 25, 2024

mkzie2 commented Dec 27, 2024

allgandalf commented Dec 30, 2024 •

edited

Loading

allgandalf commented Jan 7, 2025

allgandalf commented Jan 9, 2025

mkzie2 commented Jan 9, 2025

allgandalf commented Jan 14, 2025

mkzie2 commented Jan 14, 2025

allgandalf commented Jan 14, 2025

allgandalf commented Jan 15, 2025

mkzie2 commented Jan 15, 2025

mkzie2 commented Jan 17, 2025

allgandalf commented Jan 17, 2025

allgandalf commented Jan 17, 2025

mkzie2 commented Jan 17, 2025 •

edited

Loading

allgandalf commented Jan 17, 2025

dangrous left a comment

OSBotify commented Jan 21, 2025

github-actions bot commented Jan 23, 2025

github-actions bot commented Jan 28, 2025

fix: report fields are not disabled after disconnect accounting integration #51717

fix: report fields are not disabled after disconnect accounting integration #51717

Conversation

mkzie2 commented Oct 30, 2024 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

allgandalf commented Nov 25, 2024

allgandalf commented Dec 2, 2024

melvin-bot bot commented Dec 25, 2024

mkzie2 commented Dec 27, 2024

allgandalf commented Dec 30, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

allgandalf commented Jan 7, 2025

allgandalf commented Jan 9, 2025

mkzie2 commented Jan 9, 2025

allgandalf commented Jan 14, 2025

mkzie2 commented Jan 14, 2025

allgandalf commented Jan 14, 2025

allgandalf commented Jan 15, 2025

mkzie2 commented Jan 15, 2025

mkzie2 commented Jan 17, 2025

allgandalf commented Jan 17, 2025

allgandalf commented Jan 17, 2025

mkzie2 commented Jan 17, 2025 • edited Loading

allgandalf commented Jan 17, 2025

dangrous left a comment

Choose a reason for hiding this comment

OSBotify commented Jan 21, 2025

github-actions bot commented Jan 23, 2025

github-actions bot commented Jan 28, 2025

mkzie2 commented Oct 30, 2024 •

edited

Loading

allgandalf commented Dec 30, 2024 •

edited

Loading

mkzie2 commented Jan 17, 2025 •

edited

Loading