[HOLD for payment 2025-02-04] [$250] Report fields - Feature can be enabled in collect workspace

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.46-1
Reproducible in staging?: Y
Reproducible in production?: Y
Issue reported by: Applause Internal Team

Action Performed:

Precondition: user has Collect workspace.

1. Go ws settings > More features
2. Enable Accounting
3. Go to Accounting > Connect QBO integration
4. Disconnect QBO integration

Expected Result:

Report fields, as feature, available in Control workspace, disappeared from LHN.

Actual Result:

Report fields stays in LHN. User can access tab and add report filed to a collect workspace.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6628080_1728376180366.report_fields.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021844128989949063152
• Upwork Job ID: 1844128989949063152
• Last Price Increase: 2024-10-23
• Automatic offers:
• allgandalf | Reviewer | 104633600
• mkzie2 | Contributor | 104633601

Issue Owner

Current Issue Owner: @slafortune

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

We think that this bug might be related to #wave-control

[IuliiaHerets]

@slafortune FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[mkzie2]

Edited by proposal-police: This proposal was edited at 2024-10-09 21:40:29 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Report fields stays in LHN. User can access tab and add report filed to a collect workspace.

What is the root cause of that problem?

• When removing any connection, we didn't turn off report field feature if it is not control policy:

App/src/libs/actions/connections/index.ts

Line 22 in 3a6676e

function removePolicyConnection(policyID: string, connectionName: PolicyConnectionName) {

What changes do you think we should make in order to solve the problem?

• Add an additional logic to line:

const isCollectWorkspace = policy.type === 'team';
    if (isCollectWorkspace && ['quickbooksOnline', 'xero', 'quickbooksDesktop'].includes(connectionName)) {
        optimisticData.push({
            onyxMethod: Onyx.METHOD.MERGE,
            key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,
            value: {
                areReportFieldsEnabled: false,
                pendingFields: {
                    areReportFieldsEnabled: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
                },
            },
        });

        successData.push({
            onyxMethod: Onyx.METHOD.MERGE,
            key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,
            value: {
                pendingFields: {
                    areReportFieldsEnabled: null,
                },
            },
        });

        failureData.push({
            onyxMethod: Onyx.METHOD.MERGE,
            key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,
            value: {
                areReportFieldsEnabled: policy?.areReportFieldsEnabled,
                pendingFields: {
                    areReportFieldsEnabled: null,
                },
            },
        });
    }

• BE should fix it as well. In detail, when we disconnect, BE needs to turn off report field feature as well.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021844128989949063152

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allgandalf (External)

[allgandalf]

@slafortune , a thought:

• We should never allow the toggle of report fields unless the workspace itself in on a control plan, it's a control plan only feature, can you take it to our slack #expense channel and tag me there? the expected result doesn't seem right, please tag me there too

[melvin-bot]

@slafortune, @allgandalf Eep! 4 days overdue now. Issues have feelings too...

[allgandalf]

bump on ^ @slafortune

[trjExpensify]

Report fields are a control feature, moving this to #expense.

[slafortune]

Perfect since everything Collect or Control is going to the Expenses Project

Sorry for my delay @allgandalf

We should never allow the toggle of report fields unless the workspace itself in on a control plan, it's a control plan only feature, can you take it to our slack #expense channel and tag me there? the expected result doesn't seem right, please tag me there too

Report fields unrelated to any accounting integrations are not supported on the Collect workspace
This bug had been related to the Collect workspace project since the QBO connection is allowed on the Collect workspace - which allows for report fields.

if connected to an accounting integration that is allowed on the collect workspace - report fields are enabled. When disconnecting - report fields should be removed.

[slafortune]

Sorry - some keyboard shortcut closed that 😱

[dangrous]

Backend fix is on staging! I think you can hopefully move forward with testing the FE PR.

[allgandalf]

Thanks a lot !, @mkzie2 please open the PR for review, also merge main

[allgandalf]

lets prioritize this one @mkzie2

[mkzie2]

On my list today.

[melvin-bot]

@dangrous, @slafortune, @allgandalf, @mkzie2 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[slafortune]

@mkzie2 when will you be able to get to this?

[mkzie2]

@slafortune The PR was opened a long time ago #51717 and is under review now.

[dangrous]

Anything y'all need to get that PR pushed along? Let me know! Would love to get this merged this week.

[allgandalf]

Hopeful to get this one merged in a day or two....

[melvin-bot]

This issue has not been updated in over 15 days. @dangrous, @slafortune, @allgandalf, @mkzie2 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[mkzie2]

PR was merged.

[dangrous]

looks like this is on staging now!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.89-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: report fields are not disabled after disconnect accounting integration #51717

If no regressions arise, payment will be issued on 2025-02-04. 🎊

For reference, here are some details about the assignees on this issue:

• @allgandalf requires payment automatic offer (Reviewer)
• @mkzie2 requires payment automatic offer (Contributor)

[melvin-bot]

@allgandalf @slafortune @allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]