feat: PushRowWithModal component #51173

MrMuzyk · 2024-10-21T10:58:16Z

Details

Added a new component that is uses PushRowModal and MenuWithItemDescription that accepts list of options to display. It will be used to display various lists from Corpay, States, Provinces, European countries etc.

No test steps as it's not used anywhere yet.

Fixed Issues

$ #50895
PROPOSAL:

Tests

Same as QA steps
Verify that no errors appear in the JS console

Offline tests

QA Steps

Change workspace currency to EUR, GBP, CAD or AUD
Try to connect bank account
In the first step, new component should be displayed
Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

pushrow-android-native.mov

Android: mWeb Chrome

pushrow-android-chrome.mov

iOS: Native

pushrow-ios-native.mov

iOS: mWeb Safari

pushrow-ios-safari.mov

MacOS: Chrome / Safari

pushrow-web.mov

MacOS: Desktop

pushrow-desktop.mov

melvin-bot · 2024-10-21T11:09:28Z

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hungvu193 · 2024-10-22T02:46:04Z

Is there any way to test it?

hungvu193 · 2024-10-22T04:49:45Z

Also can you please merge main? We recently merged a PR to update node version which might lead to reassure tests failing

MrMuzyk · 2024-10-22T06:05:56Z

Is there any way to test it?

It's not used anywhere yet. Next issue that I'm planning to work on will be using it.
If it's absolutely mandatory to test it right now then I can probably add that in the frame of the flow.

Also can you please merge main? We recently merged a PR to update node version which might lead to reassure tests failing

Done

…h-row-with-modal

hungvu193 · 2024-10-22T06:21:52Z

It's not used anywhere yet. Next issue that I'm planning to work on will be using it.
If it's absolutely mandatory to test it right now then I can probably add that in the frame of the flow.

Yes please, it can be simple as much as possible.

MrMuzyk · 2024-10-22T06:51:51Z

@hungvu193 I've added it to the first screen of the frame of the flow I've previously added. Do you want me to add videos for all platforms as well?

hungvu193 · 2024-10-22T06:53:06Z

Yes please 🙇. TIA

MrMuzyk · 2024-10-22T07:12:56Z

Updated the description with videos and short QA steps

hungvu193 · 2024-10-22T08:35:12Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

// running issue

Android: mWeb Chrome

mAndroid.mov

iOS: Native

// running issue

iOS: mWeb Safari

Screen.Recording.2024-10-22.at.15.33.44.mov

MacOS: Chrome / Safari

Chrome.mov

MacOS: Desktop

Desktop.mov

hungvu193

LGTM

melvin-bot · 2024-10-23T15:46:56Z

@madmax330 looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

OSBotify · 2024-10-23T15:57:34Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-23T16:44:18Z

🚀 Deployed to staging by https://github.com/madmax330 in version: 9.0.53-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-10-23T17:45:46Z

🚀 Deployed to staging by https://github.com/madmax330 in version: 9.0.53-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

kavimuru · 2024-10-24T00:22:23Z

@hungvu193 @madmax330 We Is there any snippet to be run?

Bug6643733_1729716879087.bandicam_2024-10-23_23-47-34-363.mp4

hungvu193 · 2024-10-24T01:57:49Z

It's development only so I'm not sure if QA team can verify it

IuliiaHerets · 2024-10-24T07:36:53Z

Issue was failed because of this issue #51385

hungvu193 · 2024-10-24T07:40:17Z

It's development only, so I don't think this issue causes #51385

github-actions · 2024-10-25T02:17:41Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.53-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-10-25T07:48:45Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.53-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

suneox · 2025-01-28T05:42:58Z

src/components/PushRowWithModal/PushRowModal.tsx

+
+    return (
+        <Modal
+            onClose={onClose}


Coming from #55073: After closing the modal, we should clear the input search to ensure the current search value is reset.

feat: PushRowWithModal component

92d4020

MrMuzyk marked this pull request as ready for review October 21, 2024 11:09

MrMuzyk requested a review from a team as a code owner October 21, 2024 11:09

melvin-bot bot requested a review from hungvu193 October 21, 2024 11:09

melvin-bot bot removed the request for review from a team October 21, 2024 11:09

Merge branch 'main' of https://github.com/Expensify/App into feat/pus…

b2756a1

…h-row-with-modal

feat: showcase component usage

a5db236

hungvu193 approved these changes Oct 22, 2024

View reviewed changes

melvin-bot bot requested a review from madmax330 October 22, 2024 08:35

MrMuzyk mentioned this pull request Oct 23, 2024

feat: Step 1 country (without API calls) #51328

Merged

50 tasks

madmax330 approved these changes Oct 23, 2024

View reviewed changes

madmax330 merged commit 22ddb6d into Expensify:main Oct 23, 2024
19 checks passed

melvin-bot bot added the Emergency label Oct 23, 2024

github-actions bot mentioned this pull request Oct 23, 2024

Deploy Checklist: New Expensify 2024-10-23 #51344

Closed

42 tasks

IuliiaHerets mentioned this pull request Oct 24, 2024

Modal that shows European countries list is not being shown #51385

Closed

8 tasks

IuliiaHerets mentioned this pull request Oct 24, 2024

[$250] Android -Unable to change workspace currency on first try when tapping while keyboard is up #51389

Closed

8 tasks

melvin-bot bot mentioned this pull request Oct 25, 2024

[HOLD for payment 2024-11-01] [GR Phase 1] Create reusable “PushRowWithModal” component #50895

Closed

truph01 mentioned this pull request Dec 26, 2024

[HOLD for payment 2025-01-24] [$250] Bank account - App does not trigger required field validation when no state is selected #54572

Closed

8 tasks

suneox reviewed Jan 28, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: PushRowWithModal component #51173

feat: PushRowWithModal component #51173

MrMuzyk commented Oct 21, 2024 •

edited

Loading

melvin-bot bot commented Oct 21, 2024

hungvu193 commented Oct 22, 2024

hungvu193 commented Oct 22, 2024

MrMuzyk commented Oct 22, 2024 •

edited

Loading

hungvu193 commented Oct 22, 2024

MrMuzyk commented Oct 22, 2024

hungvu193 commented Oct 22, 2024

MrMuzyk commented Oct 22, 2024

hungvu193 commented Oct 22, 2024

hungvu193 left a comment

melvin-bot bot commented Oct 23, 2024

OSBotify commented Oct 23, 2024

github-actions bot commented Oct 23, 2024

github-actions bot commented Oct 23, 2024

kavimuru commented Oct 24, 2024

hungvu193 commented Oct 24, 2024

IuliiaHerets commented Oct 24, 2024

hungvu193 commented Oct 24, 2024

github-actions bot commented Oct 25, 2024

github-actions bot commented Oct 25, 2024

suneox Jan 28, 2025

feat: PushRowWithModal component #51173

feat: PushRowWithModal component #51173

Conversation

MrMuzyk commented Oct 21, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 21, 2024

hungvu193 commented Oct 22, 2024

hungvu193 commented Oct 22, 2024

MrMuzyk commented Oct 22, 2024 • edited Loading

hungvu193 commented Oct 22, 2024

MrMuzyk commented Oct 22, 2024

hungvu193 commented Oct 22, 2024

MrMuzyk commented Oct 22, 2024

hungvu193 commented Oct 22, 2024

Reviewer Checklist

Screenshots/Videos

hungvu193 left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Oct 23, 2024

OSBotify commented Oct 23, 2024

github-actions bot commented Oct 23, 2024

github-actions bot commented Oct 23, 2024

kavimuru commented Oct 24, 2024

hungvu193 commented Oct 24, 2024

IuliiaHerets commented Oct 24, 2024

hungvu193 commented Oct 24, 2024

github-actions bot commented Oct 25, 2024

github-actions bot commented Oct 25, 2024

suneox Jan 28, 2025

Choose a reason for hiding this comment

MrMuzyk commented Oct 21, 2024 •

edited

Loading

MrMuzyk commented Oct 22, 2024 •

edited

Loading