[$250] Android -Unable to change workspace currency on first try when tapping while keyboard is up

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.53-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Issue was found when executing this PR: #51173
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Open newDot hybrid app
2. Create a workspace
3. Go to workspace profile settings
4. Open workspace currency
5. Search for other currency for e.g "EUR"
6. Tap on the EUR currency while keyboard is up

Expected Result:

The currency gets selected and app navigates back to workspace profile settings page

Actual Result:

The currency does not get selected on first trial, user has to tap on the currency multiple of times

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6643748_1729717999123.Screen_Recording_20241024_000632.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021852235095885144546
• Upwork Job ID: 1852235095885144546
• Last Price Increase: 2024-11-01
• Automatic offers:
• shubham1206agra | Reviewer | 104728790

Issue Owner

Current Issue Owner: @jnowakow

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[ChavdaSachin]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Android -Unable to change workspace currency on first try when tapping while keyboard is up

What is the root cause of that problem?

We do not dismiss keyboard on WorkspaceProfileCurrencyPage as we do on IOURequestStepCurrency

App/src/pages/workspace/WorkspaceProfileCurrencyPage.tsx

Lines 21 to 24 in 8e13bcc

	const onSelectCurrency = (item: CurrencyListItem) => {
	Policy.updateGeneralSettings(policy?.id ?? '-1', policy?.name ?? '', item.currencyCode);
	Navigation.setNavigationActionToMicrotaskQueue(Navigation.goBack);
	};

App/src/pages/iou/request/step/IOURequestStepCurrency.tsx

Lines 57 to 64 in 8e13bcc

	const confirmCurrencySelection = (option: CurrencyListItem) => {
	Keyboard.dismiss();
	if (pageIndex !== CONST.IOU.PAGE_INDEX.CONFIRM) {
	IOU.setMoneyRequestCurrency(transactionID, option.currencyCode, action === CONST.IOU.ACTION.EDIT);
	}
	Navigation.setNavigationActionToMicrotaskQueue(() => navigateBack(option.currencyCode));
	};

What changes do you think we should make in order to solve the problem?

Add Keyboard.dismiss(); here

App/src/pages/workspace/WorkspaceProfileCurrencyPage.tsx

Lines 21 to 24 in 8e13bcc

	const onSelectCurrency = (item: CurrencyListItem) => {
	Policy.updateGeneralSettings(policy?.id ?? '-1', policy?.name ?? '', item.currencyCode);
	Navigation.setNavigationActionToMicrotaskQueue(Navigation.goBack);
	};

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[Christinadobrzyn]

Hybrid app so this needs to go through Internal to see if we want to fix it. Reaching out to the team to see if we can make this external since it's affecting another app.

https://expensify.slack.com/archives/C06ML6X0W9L/p1729837653095419?thread_ts=1729833606.671219&cid=C06ML6X0W9L

[melvin-bot]

@Christinadobrzyn Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[Christinadobrzyn]

Retested this and it's only affecting the Hybrid App not the Android Standalone app. I'm thinking we can close this but I'll double-check with the team.

https://expensify.slack.com/archives/C06ML6X0W9L/p1730174826233619

[trjExpensify]

it's only affecting the Hybrid App not the Android Standalone app.

HybridApp will be the primary app downloaded and used by customers, so we can't just blanket close these issues because they're seemingly only occurring on HybridApp only.

@Julesssss @AndrewGable @mateuuszzzzz @staszekscp @war-in any thoughts on why this can't go external, given the above RCA?

[Julesssss]

Is this reproducible on New Expensify Standalone?: Y

Retested this and it's only affecting the Hybrid App not the Android Standalone app

We should clarify with @IuliiaHerets in case this was reproducable on NewDot standalone in specific circumstances?

But yeah, this could be worked on by the SWM team.

[Christinadobrzyn]

Okay sounds good - asking QA to check if this is only happening on Android Hybrid App or on other apps with specific circumstances. I'll reach out to SWM based on the decision.

[Christinadobrzyn]

monitoring QA testing

[mvtglobally]

It is not necessarily linked to only one currency, It happens with others too. Also, tester faced this issue in different areas: time zone, incorporation state and tags and categories if there are many of them.

trim.62B04651-E688-46C6-8A57-7D4A40B841BA.MOV

trim.026B3AA3-A2AB-461F-B4D5-296C4F96E396.MOV

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021852235095885144546

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

[Christinadobrzyn]

Thanks @mvtglobally! Okay, gonna add External to see if @shubham1206agra can review this proposal or determine if we should reach out to SWM.

[shubham1206agra]

@Christinadobrzyn This proposal is not good enough. I remember there was another way to fix these problems. Let SWM fix this issue.

[Christinadobrzyn]

Reached out to SWM to see if anyone has the bandwidth to take this issue.

[jnowakow]

Hello, I'm from Software Mansion and I'll work on this issue

[melvin-bot]

📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[Christinadobrzyn]

Awesome Thanks @jnowakow! I added you to this issue, thank you for joining us!

[jnowakow]

I've build hybrid app from the newest main with newest ND main and I couldn't reproduce the problem neither on simulator nor on physical device.
I'm trying to reproduce it on other branches and in release variant

[trjExpensify]

Is it specific to some Android devices/OS version or something maybe? 🤔 @mvtglobally what device and OS was the tester using above?

[jnowakow]

I've check it on samsung galaxy a33 with android 14 and on LG K42 with android 12

[jnowakow]

Okey, I can reproduce the bug when I'm on main in OD and commit 788939a in ND. It's the PR that hybrid app currently is pointing to. So bumping the version of ND in hybrid app should fix the issue

[jnowakow]

On ND's staging branch things also seems to work as expected

[Christinadobrzyn]

Oh great @jnowakow! Thanks for the investigation.

Do you think this is resolved? I can ask QA to test again if that's the case

[jnowakow]

@Christinadobrzyn yeah I think it's resolved because I couldn't reproduce it on Monday. But let QA confirm that on the latest hybrid app build. They're build once a day so latest build should have this problem solved

[Christinadobrzyn]

Asking QA to test - https://expensify.slack.com/archives/C9YU7BX5M/p1730957039833679

[Christinadobrzyn]

QA can't reproduce this, so I think we're good to close.

I don't think there are any payouts due but let me know otherwise!

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[Christinadobrzyn]

Closing as this seems to be resolved.