Fix bad apple app site association

[marcaaron]

Details

Fixes deep links and unblocks testing via deep links on iOS. Seems this has been broken for a minute. But we need QA to test this flow in the latest staging build so I'm asking for a CP.

Fixed Issues (Comment)

$ #5029 (comment)

Tests

Can't really test this on dev because the universal link needs to be tested on staging after staging web deploys. It uses the JSON file that we are modifying here.

QA Steps

1. Navigate to https://staging.new.expensify.com/bank-account
2. Verify the deep link works

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

[github-actions]

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

[marcaaron]

On second thought we found a workaround and don't need to CP this.

[marcaaron]

Unsure if removing that label makes a CP go away... 😅

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by @deetergp in version: 1.0.94-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[mvtglobally]

@marcaaron @deetergp Should we QA on all platforms?

[marcaaron]

The only platforms we need to test this on are Android and iOS.

[marcaaron]

The change really should only affect iOS

[OSBotify]

🚀 Deployed to production by @yuwenmemon in version: 1.0.95-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅