Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2021-09-08 #5146

Closed
18 tasks done
OSBotify opened this issue Sep 8, 2021 · 14 comments
Closed
18 tasks done

Deploy Checklist: New Expensify 2021-09-08 #5146

OSBotify opened this issue Sep 8, 2021 · 14 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Sep 8, 2021
@mvtglobally
Copy link

Starting QA

@isagoico
Copy link

isagoico commented Sep 8, 2021

@roryabraham Seem like the deploy messages are failing when a new checklist is created 🤔 None of the PRs have the comment. We will start setting up QA, please let us know if there's anything wrong with the checklist.

image

Ignore me all comments are there now :)

@roryabraham
Copy link
Contributor

#5154 should be resolved in 1.0.95-1, currently being deployed here

@Julesssss
Copy link
Contributor

THe solution to this blocker: #5152 is known. We're working on the fix.

@roryabraham
Copy link
Contributor

@isagoico can we please retest both #5154 and #5152 ?

@isagoico
Copy link

isagoico commented Sep 9, 2021

Checking both #5154 and #5152, retests were a pass 🎉

@roryabraham
Copy link
Contributor

#5153 should also be fixed now, please retest 🙇

@isagoico
Copy link

isagoico commented Sep 9, 2021

Retest was a pass! Checking it off #5153 (comment)

@yuwenmemon
Copy link
Contributor

Blockers are cleared, although looks like #5014 is not checked off. It's internalQA, so will follow up in the issue.

@madmax330
Copy link
Contributor

Done: #5014 (comment)

@OSBotify OSBotify reopened this Sep 9, 2021
@OSBotify
Copy link
Contributor Author

OSBotify commented Sep 9, 2021

Sorry, only members of @Expensify/Mobile-Deployers can close deploy checklists.
Reopening!

@parasharrajat
Copy link
Member

This should be :shipit: @roryabraham .

@yuwenmemon
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

9 participants