Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat - Attachment is not appearing in preview before sending #5153

Closed
kavimuru opened this issue Sep 9, 2021 · 9 comments
Closed

Chat - Attachment is not appearing in preview before sending #5153

kavimuru opened this issue Sep 9, 2021 · 9 comments
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2

Comments

@kavimuru
Copy link

kavimuru commented Sep 9, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Log in with any account
  3. Select any conversation
  4. Click on Plus button and Select Add Attachment
  5. Select any attachment

Expected Result:

Preview of the attachment is displayed

Actual Result:

Preview of the attachment is not appearing

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • Mobile Web

Version Number: 1.0.95-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Bug5228485_Attachment

Bug5228485_Recording__335.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:

Issue was found when executing the PR #5101

View all open jobs on GitHub

@kavimuru kavimuru added the DeployBlockerCash This issue or pull request should block deployment label Sep 9, 2021
@OSBotify
Copy link
Contributor

OSBotify commented Sep 9, 2021

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Triggered auto assignment to @joelbettner (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@justinpersaud
Copy link
Contributor

This was introduced by https://github.com/Expensify/Expensify/issues/171938

The attachments are referencing blob://

I've added in blob: to the permitted img-src in the Content Security Policy. It should be working now.

@isagoico
Copy link

isagoico commented Sep 9, 2021

Retest was a pass 🎉
image

@joelbettner
Copy link
Contributor

You're a gentleman and a scholar @justinpersaud.

@isagoico
Copy link

isagoico commented Sep 10, 2021

@justinpersaud Reopening this since it's still reproducible for PDF files on build 1.0.96

image

It's not reproducible in production.

@justinpersaud
Copy link
Contributor

PR up. should be fixed soon

@justinpersaud
Copy link
Contributor

@isagoico just deployed the change and tested myself, seems to be working now

@isagoico
Copy link

It was a pass! 🎉
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants