Initialize current user's personal details when personalDetailsList is non empty and they can't be found #2250
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Julesssss
Details
Since it's possible for a user to not have personal details set we need to provide an empty object as a fallback. In the cases where a user has a
personalDetailsList
but no ownexpensify_personalDetails
bad things happen like what is linked in the issues.Fixed Issues
Fixes https://github.com/Expensify/Expensify/issues/158699
Fixes #2247
Fixes #2253
Tests
Logging in on
![Screen Shot 2021-04-06 at 2 00 50 PM](https://user-images.githubusercontent.com/32969087/113791973-8a2d5700-96e0-11eb-8017-daa3cf996438.png)
main
:Logging in on this branch:
![Screen Shot 2021-04-06 at 1 56 10 PM](https://user-images.githubusercontent.com/32969087/113791713-f3609a80-96df-11eb-88b6-951b2e8af7c7.png)
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android